sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-04-10 04:19:25 -07:00
Code Issues Packages Projects Releases Wiki Activity

docs(plans): add implementation plan for library summary replaces per-day

Browse Source 
Also corrects the spec's chart library reference (Recharts, not
ECharts) and clarifies that the backend keeps the internal
animePerDay computation as an intermediate for animeCumulative,
only dropping it from the API response.
This commit is contained in:
Kyle Yasuda
2026-04-09 21:51:02 -07:00
parent 70d52248f8
commit 928a0d6b61
2 changed files with 1356 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1347
docs/superpowers/plans/2026-04-09-library-summary-replaces-per-day.md Normal file
View File

File diff suppressed because it is too large Load Diff

19
docs/superpowers/specs/2026-04-09-library-summary-replaces-per-day-design.md
View File

@@ -69,14 +69,11 @@ type LibrarySummaryRow = {
### Removed from API response
- `animePerDay.lookups`
- `animePerDay.lookupsPerHundred`
- `animePerDay.episodes` (if no other consumer — verify during implementation)
- `animePerDay.watchTime` (if no other consumer — verify during implementation)
- `animePerDay.cards` (if no other consumer — verify during implementation)
- `animePerDay.words` (if no other consumer — verify during implementation)
Drop the entire `animePerDay` field from `TrendsDashboardQueryResult` (both backend in `src/core/services/immersion-tracker/query-trends.ts` and frontend in `stats/src/types/stats.ts`).
If all four "if no other consumer" fields can be dropped, remove the `animePerDay` object from the response entirely along with the helpers that produce it. Check every use site in `stats/` before deleting.
Internally, the existing helpers (`buildPerAnimeFromDailyRollups`, `buildEpisodesPerAnimeFromDailyRollups`) are still used as intermediates to build `animeCumulative.*` via `buildCumulativePerAnime`. Keep those helpers — just scope their output to local variables inside `getTrendsDashboard` instead of exposing them on the response. The `buildPerAnimeFromSessions` call for lookups and the `buildLookupsPerHundredPerAnime` helper become unused and can be deleted.
Before removing `animePerDay` from the frontend type, verify no other file under `stats/src/` references it. Based on current inspection, only `TrendsTab.tsx` and `stats/src/types/stats.ts` touch it.
## Frontend
@@ -101,11 +98,13 @@ Both cards use the existing chart/card wrapper styling.
### Leaderboard chart
- ECharts horizontal bar chart (matches the rest of the page).
- Recharts horizontal bar chart (matches the rest of the page — existing charts use `recharts`, not ECharts).
- Top 10 titles by watch time. If fewer titles have activity, render what's there.
- Y-axis: title, truncated with ellipsis at container width; full title on hover via ECharts tooltip.
- X-axis: minutes.
- Y-axis: title (category), truncated with ellipsis at container width; full title visible in the Recharts tooltip.
- X-axis: minutes (number).
- Use `layout="vertical"` with `YAxis dataKey="title" type="category"` and `XAxis type="number"`.
- Single series color: `#8aadf4` (matching the existing Watch Time color).
- Reuse `CHART_DEFAULTS`, `CHART_THEME`, `TOOLTIP_CONTENT_STYLE` from `stats/src/lib/chart-theme.ts` so theming matches the rest of the dashboard.
- Chart order is fixed at watch-time desc regardless of table sort — the leaderboard's meaning is fixed.
### Table