refactor: remove dead code and enable noUnusedLocals (#292)

* refactor: remove dead code and enable noUnusedLocals

- delete launcher/jimaku.ts and the launcher Args/config jimaku* fields
  that only fed it (the SUBMINER_JIMAKU_* env vars had no effect)
- delete plugin/subminer/hover.lua; nothing has sent subminer-hover-token
  since Overlay 2.0
- drop never-read anilist.characterDictionary.refreshTtlHours and
  evictionPolicy (still hidden in the settings UI for old configs)
- drop unused root deps: eslint, @fontsource-variable/geist{,-mono}
  (stats/ declares its own)
- delete the committed draft renderer-performance plan doc
- turn on noUnusedLocals for typecheck and remove what it surfaced,
  including Windows focus-handoff values computed but never consumed

* docs(changes): add docs fragment and note retired hover messages

src/core/services/anilist/anilist-updater.ts

@@ -87,20 +87,6 @@ export interface GuessAnilistMediaInfoDeps {
   runGuessit: (target: string) => Promise<string>;
 }
 
-function firstString(value: unknown): string | null {
-  if (typeof value === 'string') {
-    const trimmed = value.trim();
-    return trimmed.length > 0 ? trimmed : null;
-  }
-  if (Array.isArray(value)) {
-    for (const item of value) {
-      const candidate = firstString(item);
-      if (candidate) return candidate;
-    }
-  }
-  return null;
-}
-
 function normalizeGuessitTitlePart(value: string): string {
   return value.replace(/[._]+/g, ' ').replace(/-/g, ' ').replace(/\s+/g, ' ').trim();
 }

src/core/services/immersion-tracker-service.ts

@@ -147,16 +147,10 @@ import { enqueueWrite } from './immersion-tracker/queue';
 import { nowMs } from './immersion-tracker/time';
 import {
   DEFAULT_BATCH_SIZE,
-  DEFAULT_DAILY_ROLLUP_RETENTION_MS,
-  DEFAULT_EVENTS_RETENTION_MS,
   DEFAULT_FLUSH_INTERVAL_MS,
   DEFAULT_MAINTENANCE_INTERVAL_MS,
   DEFAULT_MAX_PAYLOAD_BYTES,
-  DEFAULT_MONTHLY_ROLLUP_RETENTION_MS,
   DEFAULT_QUEUE_CAP,
-  DEFAULT_SESSIONS_RETENTION_MS,
-  DEFAULT_TELEMETRY_RETENTION_MS,
-  DEFAULT_VACUUM_INTERVAL_MS,
   EVENT_CARD_MINED,
   EVENT_LOOKUP,
   EVENT_MEDIA_BUFFER,

src/core/services/immersion-tracker/__tests__/query.test.ts

@@ -2769,7 +2769,6 @@ test('getSessionWordsByLine joins word occurrences through imm_words.id', () =>
 
   try {
     ensureSchema(db);
-    const stmts = createTrackerPreparedStatements(db);
     const startedAtMs = 1_735_732_800_000;
     const videoId = getOrCreateVideoRecord(db, '/tmp/session-words-by-line.mkv', {
       canonicalTitle: 'Episode',

src/core/services/immersion-tracker/query-library.ts

@@ -18,7 +18,6 @@ import type {
 } from './types';
 import {
   ACTIVE_SESSION_METRICS_CTE,
-  SESSION_WORD_COUNTS_CTE,
   SESSION_WORD_COUNTS_SELECT,
   fromDbTimestamp,
   resolvedCoverBlobExpr,

src/core/services/immersion-tracker/query-maintenance.ts

@@ -16,7 +16,6 @@ import { deriveStoredPartOfSpeech } from '../tokenizer/part-of-speech';
 import {
   cleanupUnusedCoverArtBlobHash,
   findSharedCoverBlobHash,
-  toDbMs,
   toDbTimestamp,
 } from './query-shared';
 

src/core/services/immersion-tracker/storage.ts

@@ -9,7 +9,7 @@ import { ensureLexicalDailyRollupTables, markLexicalDailyRollupsReady } from './
 import { isVocabularyStatsRowVisible, type VocabularyVisibilityRow } from './vocabulary-visibility';
 import { SCHEMA_VERSION } from './types';
 import type { QueuedWrite, VideoMetadata, YoutubeVideoMetadata } from './types';
-import { toDbMs, toDbTimestamp } from './query-shared';
+import { toDbTimestamp } from './query-shared';
 
 export interface TrackerPreparedStatements {
   telemetryInsertStmt: ReturnType<DatabaseSync['prepare']>;

src/core/services/overlay-visibility.ts

@@ -74,9 +74,6 @@ export function updateVisibleOverlayVisibility(args: {
   overlayInteractionActive?: boolean;
   mainWindow: BrowserWindow | null;
   windowTracker: BaseWindowTracker | null;
-  lastKnownWindowsForegroundProcessName?: string | null;
-  windowsOverlayProcessName?: string | null;
-  windowsFocusHandoffGraceActive?: boolean;
   macOSForegroundProbeActive?: boolean;
   trackerNotReadyWarningShown: boolean;
   setTrackerNotReadyWarningShown: (shown: boolean) => void;
@@ -168,26 +165,6 @@ export function updateVisibleOverlayVisibility(args: {
     const shouldUseMacOSMousePassthrough = args.isMacOSPlatform && !overlayInteractionActive;
     const shouldDefaultToPassthrough =
       args.isWindowsPlatform || forceMousePassthrough || shouldReleaseMacOSOverlayLevel;
-    const windowsForegroundProcessName =
-      args.lastKnownWindowsForegroundProcessName?.trim().toLowerCase() ?? null;
-    const windowsOverlayProcessName = args.windowsOverlayProcessName?.trim().toLowerCase() ?? null;
-    const hasWindowsForegroundProcessSignal =
-      args.isWindowsPlatform && windowsForegroundProcessName !== null;
-    const isTrackedWindowsTargetFocused = args.windowTracker?.isTargetWindowFocused?.() ?? true;
-    const isTrackedWindowsTargetMinimized =
-      args.isWindowsPlatform &&
-      typeof args.windowTracker?.isTargetWindowMinimized === 'function' &&
-      args.windowTracker.isTargetWindowMinimized();
-    const shouldPreserveWindowsOverlayDuringFocusHandoff =
-      args.isWindowsPlatform &&
-      args.windowsFocusHandoffGraceActive === true &&
-      !!args.windowTracker &&
-      (!hasWindowsForegroundProcessSignal ||
-        windowsForegroundProcessName === 'mpv' ||
-        (windowsOverlayProcessName !== null &&
-          windowsForegroundProcessName === windowsOverlayProcessName)) &&
-      !isTrackedWindowsTargetMinimized &&
-      (args.windowTracker.isTracking() || args.windowTracker.getGeometry() !== null);
     const shouldForcePassiveReshow = args.isWindowsPlatform && !wasVisible;
     const isNonNativeOverlay = !args.isWindowsPlatform && !args.isMacOSPlatform;
     const isNonNativePassiveOverlay = isNonNativeOverlay && !overlayInteractionActive;
@@ -208,13 +185,6 @@ export function updateVisibleOverlayVisibility(args: {
       (isNonNativePassiveOverlay && !hasNonNativeInputRegion) ||
       (shouldDefaultToPassthrough && (!isVisibleOverlayFocused || shouldForcePassiveReshow));
     const shouldBindTrackedWindowsOverlay = args.isWindowsPlatform && !!args.windowTracker;
-    const shouldKeepTrackedWindowsOverlayTopmost =
-      !args.isWindowsPlatform ||
-      !args.windowTracker ||
-      isVisibleOverlayFocused ||
-      isTrackedWindowsTargetFocused ||
-      shouldPreserveWindowsOverlayDuringFocusHandoff ||
-      (hasWindowsForegroundProcessSignal && windowsForegroundProcessName === 'mpv');
     if (shouldIgnoreMouseEvents) {
       applyOverlayClickThrough(mainWindow, args.isWindowsPlatform);
     } else {

src/core/services/session-actions.ts

@@ -1,5 +1,4 @@
 import type { RuntimeOptionApplyResult, RuntimeOptionId } from '../../types';
-import type { SessionActionId } from '../../types/session-bindings';
 import type { SessionActionDispatchRequest } from '../../types/runtime';
 
 export interface SessionActionExecutorDeps {

src/core/services/stats-sync/merge-rollups.ts

@@ -1,4 +1,4 @@
-import { selectAll, type SqlRow, type SyncDb } from './libsql-driver';
+import { selectAll, type SyncDb } from './libsql-driver';
 import { nowDbTimestamp, tableExists, type SyncMergeSummary } from './shared';
 
 const LOCAL_DAY_EXPR = `CAST(julianday(CAST(started_at_ms AS REAL) / 1000, 'unixepoch', 'localtime') - 2440587.5 AS INTEGER)`;

src/core/services/subtitle-cue-parser.test.ts

@@ -1,7 +1,6 @@
 import assert from 'node:assert/strict';
 import test from 'node:test';
 import { parseSrtCues, parseAssCues, parseSubtitleCues } from './subtitle-cue-parser';
-import type { SubtitleCue } from '../../types';
 
 test('parseSrtCues parses basic SRT content', () => {
   const content = [

src/core/services/tokenizer.ts

@@ -608,14 +608,6 @@ function getYomitanFrequencyRank(
     return null;
   }
 
-  const normalizedHeadword = token.headword.trim();
-  const normalizedSurface = token.surface.trim();
-  const isInflectedHeadwordFallback =
-    matchMode === 'headword' &&
-    normalizedCandidateText === normalizedHeadword &&
-    normalizedSurface.length > 0 &&
-    normalizedSurface !== normalizedHeadword;
-
   return selectBestYomitanFrequencyRank(candidateEntries);
 }
 

src/core/services/tokenizer/annotation-stage.ts

@@ -390,23 +390,6 @@ function isReduplicatedKanaSfx(text: string): boolean {
   return chars.slice(0, half).join('') === chars.slice(half).join('');
 }
 
-function isReduplicatedKanaSfxWithOptionalTrailingTo(text: string): boolean {
-  const normalized = normalizeKana(text);
-  if (!normalized) {
-    return false;
-  }
-
-  if (isReduplicatedKanaSfx(normalized)) {
-    return true;
-  }
-
-  if (normalized.length <= 1 || !normalized.endsWith('と')) {
-    return false;
-  }
-
-  return isReduplicatedKanaSfx(normalized.slice(0, -1));
-}
-
 function hasAdjacentKanaRepeat(text: string): boolean {
   const normalized = normalizeKana(text);
   if (!normalized) {