refactor: remove dead code and enable noUnusedLocals (#292)

* refactor: remove dead code and enable noUnusedLocals

- delete launcher/jimaku.ts and the launcher Args/config jimaku* fields
  that only fed it (the SUBMINER_JIMAKU_* env vars had no effect)
- delete plugin/subminer/hover.lua; nothing has sent subminer-hover-token
  since Overlay 2.0
- drop never-read anilist.characterDictionary.refreshTtlHours and
  evictionPolicy (still hidden in the settings UI for old configs)
- drop unused root deps: eslint, @fontsource-variable/geist{,-mono}
  (stats/ declares its own)
- delete the committed draft renderer-performance plan doc
- turn on noUnusedLocals for typecheck and remove what it surfaced,
  including Windows focus-handoff values computed but never consumed

* docs(changes): add docs fragment and note retired hover messages

src/config/definitions/defaults-integrations.ts

@@ -133,9 +133,7 @@ export const INTEGRATIONS_DEFAULT_CONFIG: Pick<
     enabled: false,
     accessToken: '',
     characterDictionary: {
-      refreshTtlHours: 168,
       maxLoaded: 3,
-      evictionPolicy: 'delete',
       profileScope: 'all',
       collapsibleSections: {
         description: false,

src/config/definitions/domain-registry.test.ts

@@ -37,8 +37,6 @@ function collectConfigLeafPaths(config: ResolvedConfig): string[] {
 // an allowlist entry. Only allowlist a path when the registry is genuinely
 // the wrong surface for it.
 const UNDOCUMENTED_LEAVES: ReadonlySet<string> = new Set([
-  'anilist.characterDictionary.evictionPolicy',
-  'anilist.characterDictionary.refreshTtlHours',
   'keybindings',
   'subtitleStyle.backdropFilter',
   'subtitleStyle.backgroundColor',

src/config/resolve/integrations.ts

@@ -94,27 +94,6 @@ export function applyIntegrationConfig(context: ResolveContext): void {
     if (isObject(src.anilist.characterDictionary)) {
       const characterDictionary = src.anilist.characterDictionary;
 
-      const refreshTtlHours = asNumber(characterDictionary.refreshTtlHours);
-      if (refreshTtlHours !== undefined) {
-        const normalized = Math.min(24 * 365, Math.max(1, Math.floor(refreshTtlHours)));
-        if (normalized !== refreshTtlHours) {
-          warn(
-            'anilist.characterDictionary.refreshTtlHours',
-            characterDictionary.refreshTtlHours,
-            normalized,
-            'Out of range; clamped to 1..8760 hours.',
-          );
-        }
-        resolved.anilist.characterDictionary.refreshTtlHours = normalized;
-      } else if (characterDictionary.refreshTtlHours !== undefined) {
-        warn(
-          'anilist.characterDictionary.refreshTtlHours',
-          characterDictionary.refreshTtlHours,
-          resolved.anilist.characterDictionary.refreshTtlHours,
-          'Expected number.',
-        );
-      }
-
       const maxLoaded = asNumber(characterDictionary.maxLoaded);
       if (maxLoaded !== undefined) {
         const normalized = Math.min(20, Math.max(1, Math.floor(maxLoaded)));
@@ -136,28 +115,6 @@ export function applyIntegrationConfig(context: ResolveContext): void {
         );
       }
 
-      const evictionPolicyRaw = asString(characterDictionary.evictionPolicy);
-      if (evictionPolicyRaw !== undefined) {
-        const evictionPolicy = evictionPolicyRaw.trim().toLowerCase();
-        if (evictionPolicy === 'disable' || evictionPolicy === 'delete') {
-          resolved.anilist.characterDictionary.evictionPolicy = evictionPolicy;
-        } else {
-          warn(
-            'anilist.characterDictionary.evictionPolicy',
-            characterDictionary.evictionPolicy,
-            resolved.anilist.characterDictionary.evictionPolicy,
-            "Expected one of: 'disable', 'delete'.",
-          );
-        }
-      } else if (characterDictionary.evictionPolicy !== undefined) {
-        warn(
-          'anilist.characterDictionary.evictionPolicy',
-          characterDictionary.evictionPolicy,
-          resolved.anilist.characterDictionary.evictionPolicy,
-          'Expected string.',
-        );
-      }
-
       const profileScopeRaw = asString(characterDictionary.profileScope);
       if (profileScopeRaw !== undefined) {
         const profileScope = profileScopeRaw.trim().toLowerCase();

src/config/resolve/jellyfin.test.ts

@@ -97,9 +97,7 @@ test('anilist character dictionary fields are parsed, clamped, and enum-validate
   const { context, warnings } = createResolveContext({
     anilist: {
       characterDictionary: {
-        refreshTtlHours: 0,
         maxLoaded: 99,
-        evictionPolicy: 'purge' as never,
         profileScope: 'global' as never,
         collapsibleSections: {
           description: true,
@@ -112,9 +110,7 @@ test('anilist character dictionary fields are parsed, clamped, and enum-validate
 
   applyIntegrationConfig(context);
 
-  assert.equal(context.resolved.anilist.characterDictionary.refreshTtlHours, 1);
   assert.equal(context.resolved.anilist.characterDictionary.maxLoaded, 20);
-  assert.equal(context.resolved.anilist.characterDictionary.evictionPolicy, 'delete');
   assert.equal(context.resolved.anilist.characterDictionary.profileScope, 'all');
   assert.equal(context.resolved.anilist.characterDictionary.collapsibleSections.description, true);
   assert.equal(
@@ -124,9 +120,7 @@ test('anilist character dictionary fields are parsed, clamped, and enum-validate
   assert.equal(context.resolved.anilist.characterDictionary.collapsibleSections.voicedBy, true);
 
   const warnedPaths = warnings.map((warning) => warning.path);
-  assert.ok(warnedPaths.includes('anilist.characterDictionary.refreshTtlHours'));
   assert.ok(warnedPaths.includes('anilist.characterDictionary.maxLoaded'));
-  assert.ok(warnedPaths.includes('anilist.characterDictionary.evictionPolicy'));
   assert.ok(warnedPaths.includes('anilist.characterDictionary.profileScope'));
   assert.ok(
     warnedPaths.includes('anilist.characterDictionary.collapsibleSections.characterInformation'),
@@ -134,7 +128,7 @@ test('anilist character dictionary fields are parsed, clamped, and enum-validate
 });
 
 test('yomitan externalProfilePath is trimmed and invalid values warn', () => {
-  const { context, warnings } = createResolveContext({
+  const { context } = createResolveContext({
     yomitan: {
       externalProfilePath: '  /tmp/gsm-profile  ',
     },

src/config/template.ts

@@ -18,10 +18,6 @@ const TOP_LEVEL_SECTION_DESCRIPTION_BY_KEY = new Map(
   CONFIG_TEMPLATE_SECTIONS.map((section) => [String(section.key), section.description[0] ?? '']),
 );
 const SUBTITLE_CSS_SCOPES: SubtitleCssScope[] = ['primary', 'secondary', 'sidebar'];
-const HIDDEN_TEMPLATE_PATHS = [
-  'anilist.characterDictionary.evictionPolicy',
-  'anilist.characterDictionary.refreshTtlHours',
-];
 
 function normalizeCommentText(value: string): string {
   return value.replace(/\s+/g, ' ').replace(/\*\//g, '*\\/').trim();
@@ -176,9 +172,6 @@ function renderSection(
 function createTemplateConfig(config: ResolvedConfig): ResolvedConfig {
   const templateConfig = deepCloneConfig(config);
   foldSubtitleCssManagedDefaults(templateConfig);
-  for (const hiddenPath of HIDDEN_TEMPLATE_PATHS) {
-    deleteValueAtPath(templateConfig, hiddenPath);
-  }
   if (templateConfig.keybindings.length === 0) {
     templateConfig.keybindings = DEFAULT_KEYBINDINGS.map((binding) => ({
       key: binding.key,