fix: address latest coderabbit feedback

This commit is contained in:
2026-04-02 22:13:34 -07:00
parent 564a295e5f
commit 8520a4d068
15 changed files with 446 additions and 61 deletions

View File

@@ -1,4 +1,4 @@
import { createDiscordPresenceService } from '../../core/services';
import { createDiscordPresenceService } from '../../core/services/discord-presence';
import type { ResolvedConfig } from '../../types';
import { createDiscordRpcClient } from './discord-rpc-client.js';
@@ -95,6 +95,10 @@ export function createDiscordPresenceRuntimeFromMainState(input: {
}) {
const sessionStartedAtMs = Date.now();
let mediaDurationSec: number | null = null;
const stopCurrentDiscordPresenceService = async (): Promise<void> => {
await input.appState.discordPresenceService?.stop?.();
input.appState.discordPresenceService = null;
};
const discordPresenceRuntime = createDiscordPresenceRuntime({
getDiscordPresenceService: () => input.appState.discordPresenceService,
@@ -114,10 +118,11 @@ export function createDiscordPresenceRuntimeFromMainState(input: {
const initializeDiscordPresenceService = async (): Promise<void> => {
if (input.getResolvedConfig().discordPresence.enabled !== true) {
input.appState.discordPresenceService = null;
await stopCurrentDiscordPresenceService();
return;
}
await stopCurrentDiscordPresenceService();
input.appState.discordPresenceService = createDiscordPresenceService({
config: input.getResolvedConfig().discordPresence,
createClient: () => createDiscordRpcClient(input.appId),