sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-06-10 03:13:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: suppress overlay subtitle immediately when character dictionary modal opens (#84)

Browse Source
This commit is contained in:
Kyle Yasuda
2026-05-25 02:30:33 -07:00
committed by GitHub
parent 9fe13601fb
commit 7e6f9672cf
15 changed files with 307 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/runtime/startup-osd-sequencer.test.ts
+40 -2
View File
@@ -100,7 +100,7 @@ test('startup OSD replaces earlier dictionary progress with later building progr
]);
});
test('startup OSD skips buffered dictionary ready messages when progress completed before it became visible', () => {
test('startup OSD shows dictionary ready when progress completed before it became visible', () => {
const osdMessages: string[] = [];
const sequencer = createStartupOsdSequencer({
showOsd: (message) => {
@@ -117,7 +117,10 @@ test('startup OSD skips buffered dictionary ready messages when progress complet
sequencer.markTokenizationReady();
sequencer.markAnnotationLoadingComplete('Subtitle annotations loaded');
assert.deepEqual(osdMessages, ['Subtitle annotations loaded']);
assert.deepEqual(osdMessages, [
'Character dictionary ready for Frieren',
'Subtitle annotations loaded',
]);
});
test('startup OSD shows dictionary failure after annotation loading completes', () => {
@@ -184,3 +187,38 @@ test('startup OSD shows later dictionary progress immediately once tokenization
'Generating character dictionary for Frieren...',
]);
});
test('startup OSD keeps dictionary progress pending when mpv osd is unavailable', () => {
const osdMessages: string[] = [];
let osdAvailable = false;
const sequencer = createStartupOsdSequencer({
showOsd: (message) => {
osdMessages.push(message);
return osdAvailable;
},
});
sequencer.markTokenizationReady();
sequencer.notifyCharacterDictionaryStatus(
makeDictionaryEvent('generating', 'Generating character dictionary for Frieren...'),
);
sequencer.notifyCharacterDictionaryStatus(
makeDictionaryEvent('ready', 'Character dictionary ready for Frieren'),
);
assert.deepEqual(osdMessages, [
'Generating character dictionary for Frieren...',
'Character dictionary ready for Frieren',
]);
osdAvailable = true;
sequencer.notifyCharacterDictionaryStatus(
makeDictionaryEvent('ready', 'Character dictionary ready for Frieren'),
);
assert.deepEqual(osdMessages, [
'Generating character dictionary for Frieren...',
'Character dictionary ready for Frieren',
'Character dictionary ready for Frieren',
]);
});