refactor(ipc): remove dead preload methods and the ASS line broadcast (#293)

Drop 16 overlay preload methods with no caller (onSubtitleAss,
getCurrentSubtitleAss, onVisibility, getOverlayVisibility,
openYomitanSettings, quitApp, toggleOverlay, getMecabStatus,
setMecabEnabled, getKeybindings, saveControllerPreference,
getAnkiConnectStatus, setAnkiConnectEnabled, clearAnkiConnectHistory,
cycleRuntimeOption, appendClipboardVideoToQueue) along with their
IPC_CHANNELS keys, handlers, validators and dep plumbing.

With both ASS consumers gone, stop observing sub-text/ass in mpv and
remove the subtitle-ass-change event chain and appState.currentSubAssText.
The main-process functions these wrapped stay; tray, CLI, shortcuts and
session actions still use them.

src/main/runtime/composers/mpv-runtime-composer.test.ts

@@ -45,7 +45,6 @@ function createDefaultMpvFixture() {
         immersionTracker: null,
         subtitleTimingTracker: null,
         currentSubText: '',
-        currentSubAssText: '',
         playbackPaused: null,
         previousSecondarySubVisibility: null,
       },

src/main/runtime/mpv-client-event-bindings.ts

@@ -1,7 +1,6 @@
 type MpvBindingEventName =
   | 'connection-change'
   | 'subtitle-change'
-  | 'subtitle-ass-change'
   | 'secondary-subtitle-change'
   | 'subtitle-track-change'
   | 'secondary-subtitle-track-change'
@@ -89,7 +88,6 @@ export function createHandleMpvSubtitleTimingHandler(deps: {
 export function createBindMpvClientEventHandlers(deps: {
   onConnectionChange: (payload: { connected: boolean }) => void;
   onSubtitleChange: (payload: { text: string }) => void;
-  onSubtitleAssChange: (payload: { text: string }) => void;
   onSecondarySubtitleChange: (payload: { text: string }) => void;
   onSubtitleTrackChange: (payload: { sid: number | null }) => void;
   onSecondarySubtitleTrackChange: (payload: { sid: number | null }) => void;
@@ -108,7 +106,6 @@ export function createBindMpvClientEventHandlers(deps: {
   return (mpvClient: MpvEventClient): void => {
     mpvClient.on('connection-change', deps.onConnectionChange);
     mpvClient.on('subtitle-change', deps.onSubtitleChange);
-    mpvClient.on('subtitle-ass-change', deps.onSubtitleAssChange);
     mpvClient.on('secondary-subtitle-change', deps.onSecondarySubtitleChange);
     mpvClient.on('subtitle-track-change', deps.onSubtitleTrackChange);
     mpvClient.on('secondary-subtitle-track-change', deps.onSecondarySubtitleTrackChange);

src/main/runtime/mpv-main-event-actions.ts

@@ -49,16 +49,6 @@ export function createHandleMpvSubtitleChangeHandler(deps: {
   };
 }
 
-export function createHandleMpvSubtitleAssChangeHandler(deps: {
-  setCurrentSubAssText: (text: string) => void;
-  broadcastSubtitleAss: (text: string) => void;
-}) {
-  return ({ text }: { text: string }): void => {
-    deps.setCurrentSubAssText(text);
-    deps.broadcastSubtitleAss(text);
-  };
-}
-
 export function createHandleMpvSecondarySubtitleChangeHandler(deps: {
   broadcastSecondarySubtitle: (text: string) => void;
 }) {

src/main/runtime/mpv-main-event-bindings.test.ts

@@ -29,8 +29,6 @@ function createDeps(overrides: Partial<Deps> = {}): Deps {
     onSubtitleChange: () => {},
     refreshDiscordPresence: () => {},
 
-    setCurrentSubAssText: () => {},
-    broadcastSubtitleAss: () => {},
     broadcastSecondarySubtitle: () => {},
 
     updateCurrentMediaPath: () => {},

src/main/runtime/mpv-main-event-bindings.ts

@@ -10,7 +10,6 @@ import {
   createHandleMpvPauseChangeHandler,
   createHandleMpvSecondarySubtitleChangeHandler,
   createHandleMpvSecondarySubtitleVisibilityHandler,
-  createHandleMpvSubtitleAssChangeHandler,
   createHandleMpvSubtitleChangeHandler,
   createHandleMpvSubtitleMetricsChangeHandler,
   createHandleMpvTimePosChangeHandler,
@@ -52,8 +51,6 @@ export function createBindMpvMainEventHandlersHandler(deps: {
   logSubtitleProcessingDebug?: (message: string) => void;
   refreshDiscordPresence: () => void;
 
-  setCurrentSubAssText: (text: string) => void;
-  broadcastSubtitleAss: (text: string) => void;
   broadcastSecondarySubtitle: (text: string) => void;
   onSubtitleTrackChange?: (sid: number | null) => void;
   onSecondarySubtitleTrackChange?: (sid: number | null) => void;
@@ -135,10 +132,6 @@ export function createBindMpvMainEventHandlersHandler(deps: {
         : undefined,
       refreshDiscordPresence: () => deps.refreshDiscordPresence(),
     });
-    const handleMpvSubtitleAssChange = createHandleMpvSubtitleAssChangeHandler({
-      setCurrentSubAssText: (text) => deps.setCurrentSubAssText(text),
-      broadcastSubtitleAss: (text) => deps.broadcastSubtitleAss(text),
-    });
     const handleMpvSecondarySubtitleChange = createHandleMpvSecondarySubtitleChangeHandler({
       broadcastSecondarySubtitle: (text) => deps.broadcastSecondarySubtitle(text),
     });
@@ -200,7 +193,6 @@ export function createBindMpvMainEventHandlersHandler(deps: {
     createBindMpvClientEventHandlers({
       onConnectionChange: handleMpvConnectionChangeWithSidebarReset,
       onSubtitleChange: handleMpvSubtitleChange,
-      onSubtitleAssChange: handleMpvSubtitleAssChange,
       onSecondarySubtitleChange: handleMpvSecondarySubtitleChange,
       onSubtitleTrackChange: ({ sid }) => deps.onSubtitleTrackChange?.(sid),
       onSecondarySubtitleTrackChange: ({ sid }) => deps.onSecondarySubtitleTrackChange?.(sid),

src/main/runtime/mpv-main-event-main-deps.test.ts

@@ -20,7 +20,6 @@ function buildMainDeps(
     immersionTracker: null,
     subtitleTimingTracker: null,
     currentSubText: '',
-    currentSubAssText: '',
     playbackPaused: null,
     previousSecondarySubVisibility: false,
     ...appStateOverrides,

src/main/runtime/mpv-main-event-main-deps.ts

@@ -46,7 +46,6 @@ export function createBuildBindMpvMainEventHandlersMainDepsHandler(deps: {
     activeParsedSubtitleSource?: string | null;
     currentMediaPath?: string | null;
     currentSubText: string;
-    currentSubAssText: string;
     currentSubtitleData?: SubtitleData | null;
     playbackPaused: boolean | null;
     previousSecondarySubVisibility: boolean | null;
@@ -300,11 +299,6 @@ export function createBuildBindMpvMainEventHandlersMainDepsHandler(deps: {
       ? (trackList: unknown[] | null) => deps.onSubtitleTrackListChange!(trackList)
       : undefined,
     refreshDiscordPresence: () => deps.refreshDiscordPresence(),
-    setCurrentSubAssText: (text: string) => {
-      deps.appState.currentSubAssText = text;
-    },
-    broadcastSubtitleAss: (text: string) =>
-      deps.broadcastToOverlayWindows('subtitle-ass:set', text),
     broadcastSecondarySubtitle: (text: string) => {
       if (deps.onSecondarySubtitleChange) {
         deps.onSecondarySubtitleChange(text);