sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-02-28 06:22:45 -08:00
Code Issues Packages Projects Releases Wiki Activity

docs: align architecture and contributor guidance with current services

Browse Source
This commit is contained in:
kyasuda
2026-02-10 13:17:56 -08:00
committed by sudacode
parent 79b580e033
commit 744d460e1d
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs/architecture.md
View File

@@ -23,7 +23,7 @@ SubMiner uses a service-oriented Electron main-process architecture where `src/m
- Provides a narrow state API used by `main.ts` and overlay services. - Provides a narrow state API used by `main.ts` and overlay services.
- `src/core/services/*` - `src/core/services/*`
- Stateless or narrowly stateful units for a specific responsibility. - Stateless or narrowly stateful units for a specific responsibility.
- Examples: startup bootstrap, app lifecycle hooks, CLI command handling, IPC registration, overlay visibility, MPV IPC behavior, shortcut registration, subtitle websocket, jimaku/subsync helpers. - Examples: startup bootstrap/ready flow, app lifecycle wiring, CLI command handling, IPC registration, overlay visibility, MPV IPC behavior, shortcut registration, subtitle websocket, jimaku/subsync helpers.
- `src/core/utils/*` - `src/core/utils/*`
- Pure helpers and coercion/config utilities. - Pure helpers and coercion/config utilities.
- `src/cli/*` - `src/cli/*`
@@ -41,7 +41,7 @@ Most runtime code follows a dependency-injection pattern:
1. Define a service interface in `src/core/services/*`. 1. Define a service interface in `src/core/services/*`.
2. Keep core logic in pure or side-effect-bounded functions. 2. Keep core logic in pure or side-effect-bounded functions.
3. Build runtime deps in `main.ts`; use `*-deps-runtime-service.ts` helpers only when they add real adaptation logic. 3. Build runtime deps in `main.ts`; extract an adapter/helper only when it adds meaningful behavior or reuse.
4. Call the service from lifecycle/command wiring points. 4. Call the service from lifecycle/command wiring points.
This keeps side effects explicit and makes behavior easy to unit-test with fakes. This keeps side effects explicit and makes behavior easy to unit-test with fakes.
@@ -49,15 +49,15 @@ This keeps side effects explicit and makes behavior easy to unit-test with fakes
## Lifecycle Model ## Lifecycle Model
- Startup: - Startup:
- `startup-bootstrap-runtime-service` handles initial argv/env/backend setup and decides generate-config flow vs app lifecycle start. - `runStartupBootstrapRuntimeService` handles initial argv/env/backend setup and decides generate-config flow vs app lifecycle start.
- `app-lifecycle-service` handles Electron single-instance + lifecycle event registration. - `app-lifecycle-service` handles Electron single-instance + lifecycle event registration.
- `startup-lifecycle-hooks-runtime-service` wires app-ready and app-shutdown hooks. - `runAppReadyRuntimeService` performs ready-time initialization (config load, websocket policy, tokenizer/tracker setup, overlay auto-init decisions).
- Runtime: - Runtime:
- CLI/shortcut/IPC events map to service calls. - CLI/shortcut/IPC events map to service calls.
- Overlay and MPV state sync through dedicated services. - Overlay and MPV state sync through dedicated services.
- Runtime options and mining flows are coordinated via service boundaries. - Runtime options and mining flows are coordinated via service boundaries.
- Shutdown: - Shutdown:
- `app-shutdown-runtime-service` coordinates cleanup ordering (shortcuts, sockets, trackers, integrations). - `startAppLifecycleService` registers cleanup hooks (`will-quit`) while teardown behavior stays delegated to focused services from `main.ts`.
## Why This Design ## Why This Design

2
docs/development.md
View File

@@ -9,7 +9,7 @@ The current runtime design, composition model, and extension guidelines are docu
Contributor guidance: Contributor guidance:
- Overlay window/visibility state is owned by `src/core/services/overlay-manager-service.ts`. - Overlay window/visibility state is owned by `src/core/services/overlay-manager-service.ts`.
- Prefer direct inline deps objects in `main.ts` for simple pass-through wiring. - Prefer direct inline deps objects in `main.ts` for simple pass-through wiring.
- Add a `*-deps-runtime-service.ts` helper only when it performs meaningful adaptation (not identity mapping). - Add a helper/adapter service only when it performs meaningful adaptation, validation, or reuse (not identity mapping).
## Environment Variables ## Environment Variables