feat: add app-owned YouTube subtitle flow with absPlayer-style parsing (#31)

* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
2026-05-13 20:12:54 -07:00 · 2026-03-24 00:01:24 -07:00
parent c17f0a4080
commit 5feed360ca
219 changed files with 12778 additions and 1052 deletions
@@ -0,0 +1,100 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { openYoutubeTrackPicker } from './youtube-picker-open';
+import type { YoutubePickerOpenPayload } from '../../types';
+
+const payload: YoutubePickerOpenPayload = {
+  sessionId: 'yt-1',
+  url: 'https://example.com/watch?v=abc',
+  tracks: [],
+  defaultPrimaryTrackId: null,
+  defaultSecondaryTrackId: null,
+  hasTracks: false,
+};
+
+test('youtube picker open prefers dedicated modal window on first attempt', async () => {
+  const sends: Array<{
+    channel: string;
+    payload: YoutubePickerOpenPayload;
+    options: {
+      restoreOnModalClose: 'youtube-track-picker';
+      preferModalWindow: boolean;
+    };
+  }> = [];
+
+  const opened = await openYoutubeTrackPicker(
+    {
+      sendToActiveOverlayWindow: (channel, nextPayload, options) => {
+        sends.push({
+          channel,
+          payload: nextPayload as YoutubePickerOpenPayload,
+          options: options as {
+            restoreOnModalClose: 'youtube-track-picker';
+            preferModalWindow: boolean;
+          },
+        });
+        return true;
+      },
+      waitForModalOpen: async () => true,
+      logWarn: () => {},
+    },
+    payload,
+  );
+
+  assert.equal(opened, true);
+  assert.deepEqual(sends, [
+    {
+      channel: 'youtube:picker-open',
+      payload,
+      options: {
+        restoreOnModalClose: 'youtube-track-picker',
+        preferModalWindow: true,
+      },
+    },
+  ]);
+});
+
+test('youtube picker open retries on the dedicated modal window after open timeout', async () => {
+  const preferModalWindowValues: boolean[] = [];
+  const warns: string[] = [];
+  let waitCalls = 0;
+
+  const opened = await openYoutubeTrackPicker(
+    {
+      sendToActiveOverlayWindow: (_channel, _payload, options) => {
+        preferModalWindowValues.push(Boolean(options?.preferModalWindow));
+        return true;
+      },
+      waitForModalOpen: async () => {
+        waitCalls += 1;
+        return waitCalls === 2;
+      },
+      logWarn: (message) => {
+        warns.push(message);
+      },
+    },
+    payload,
+  );
+
+  assert.equal(opened, true);
+  assert.deepEqual(preferModalWindowValues, [true, true]);
+  assert.equal(
+    warns.includes(
+      'YouTube subtitle picker did not acknowledge modal open on first attempt; retrying dedicated modal window.',
+    ),
+    true,
+  );
+});
+
+test('youtube picker open fails when the dedicated modal window cannot be targeted', async () => {
+  const opened = await openYoutubeTrackPicker(
+    {
+      sendToActiveOverlayWindow: () => false,
+      waitForModalOpen: async () => true,
+      logWarn: () => {},
+    },
+    payload,
+  );
+
+  assert.equal(opened, false);
+});