mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-11-10 04:46:07 -08:00
fix(e2e): disable mpv direct rendering on macOS to avoid loadfile hang
- Pass `--vd-lavc-dr=no` alongside `--vo=libmpv` on darwin - cocoa-cb answers DR image requests only from its main queue, which can stall on CI runners and freeze mpv's core and IPC with no timeout
This commit is contained in:
1 file changed
+4
-1
+4
-1
@@ -21,7 +21,10 @@ function videoOutputArgs(display: E2eDisplay): string[] {
|
||||
// gpu-next's Vulkan path (libplacebo over MoltenVK) segfaults on the first frame
|
||||
// on GitHub's paravirtual macOS GPU with libplacebo 7.387. `--vo=libmpv` is mpv's
|
||||
// cocoa-cb OpenGL output, which avoids it and still opens the window the overlay tracks.
|
||||
if (process.platform === 'darwin') return ['--vo=libmpv'];
|
||||
// Each new decoder asks that render thread for a direct-rendering image and waits with no
|
||||
// timeout. cocoa-cb only answers from its main queue, which can stall on this runner, so a
|
||||
// `loadfile` could freeze mpv's core and its IPC for good. `--vd-lavc-dr=no` skips the request.
|
||||
if (process.platform === 'darwin') return ['--vo=libmpv', '--vd-lavc-dr=no'];
|
||||
return [];
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user