sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-06-10 03:13:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(anki): honor runtime AnkiConnect URL override in Open in Anki fallba

Browse Source 
- Use getEffectiveAnkiConnectConfig for fallback client URL resolution
- Fall back to DEFAULT_CONFIG.ankiConnect.url when effective URL is unset
This commit is contained in:
Kyle Yasuda
2026-06-09 00:44:28 -07:00
parent a15fb39847
commit 5cfb2c75ba
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main.ts
+7 -1
View File
@@ -3491,7 +3491,13 @@ async function openAnkiCardFromNotification(noteId: number): Promise<void> {
return;
}
const fallbackClient = new AnkiConnectClient(getResolvedConfig().ankiConnect.url);
const resolvedConfig = getResolvedConfig();
const effectiveAnkiConfig =
appState.runtimeOptionsManager?.getEffectiveAnkiConnectConfig(resolvedConfig.ankiConnect) ??
resolvedConfig.ankiConnect;
const fallbackClient = new AnkiConnectClient(
effectiveAnkiConfig.url || DEFAULT_CONFIG.ankiConnect.url,
);
await fallbackClient.openNoteInBrowser(noteId);
}
src/main/main-wiring.test.ts
+2 -1
View File
@@ -174,7 +174,8 @@ test('update overlay notification action triggers install flow', () => {
assert.match(source, /installWhenAvailable:\s*true/);
assert.match(source, /actionId === OPEN_ANKI_CARD_ACTION_ID && noteId !== undefined/);
assert.match(source, /appState\.ankiIntegration\?\.openNoteInAnki\(noteId\)/);
assert.match(source, /new AnkiConnectClient\(getResolvedConfig\(\)\.ankiConnect\.url/);
assert.match(source, /appState\.runtimeOptionsManager\?\.getEffectiveAnkiConnectConfig/);
assert.match(source, /new AnkiConnectClient\(\s*effectiveAnkiConfig\.url \|\| DEFAULT_CONFIG\.ankiConnect\.url/);
assert.match(source, /fallbackClient\.openNoteInBrowser\(noteId\)/);
});