sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-22 02:56:24 -07:00
Code Issues Packages Projects Releases Wiki Activity

Summarize JLPT duplicate term conflicts into a single startup log (#26)

Browse Source
This commit is contained in:
Kyle Yasuda
2026-03-16 01:08:40 -07:00
committed by GitHub
parent e35aac6ee0
commit 50b45cac0b
3 changed files with 106 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
src/core/services/jlpt-vocab.test.ts
View File

@@ -6,9 +6,16 @@ import test from 'node:test';
import { createJlptVocabularyLookup } from './jlpt-vocab';
test('createJlptVocabularyLookup loads JLPT bank entries and resolves known levels', async () => {
function createTempDir(): string {
return fs.mkdtempSync(path.join(os.tmpdir(), 'subminer-jlpt-dict-'));
}
test('createJlptVocabularyLookup loads JLPT bank entries and resolves known levels', async (t) => {
const logs: string[] = [];
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'subminer-jlpt-dict-'));
const tempDir = createTempDir();
t.after(() => {
fs.rmSync(tempDir, { recursive: true, force: true });
});
fs.writeFileSync(
path.join(tempDir, 'term_meta_bank_5.json'),
JSON.stringify([
@@ -37,8 +44,11 @@ test('createJlptVocabularyLookup loads JLPT bank entries and resolves known leve
);
});
test('createJlptVocabularyLookup does not require synchronous fs APIs', async () => {
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'subminer-jlpt-dict-'));
test('createJlptVocabularyLookup does not require synchronous fs APIs', async (t) => {
const tempDir = createTempDir();
t.after(() => {
fs.rmSync(tempDir, { recursive: true, force: true });
});
fs.writeFileSync(
path.join(tempDir, 'term_meta_bank_4.json'),
JSON.stringify([['見る', 1, { frequency: { displayValue: 3 } }]]),
@@ -73,3 +83,47 @@ test('createJlptVocabularyLookup does not require synchronous fs APIs', async ()
(fs as unknown as Record<string, unknown>).existsSync = existsSync;
}
});
test('createJlptVocabularyLookup summarizes duplicate JLPT terms without per-entry log spam', async (t) => {
const logs: string[] = [];
const tempDir = createTempDir();
t.after(() => {
fs.rmSync(tempDir, { recursive: true, force: true });
});
fs.writeFileSync(
path.join(tempDir, 'term_meta_bank_1.json'),
JSON.stringify([
['余り', 1, { frequency: { displayValue: 'N1' }, reading: 'あんまり' }],
['私', 2, { frequency: { displayValue: 'N1' }, reading: 'あたし' }],
]),
);
fs.writeFileSync(path.join(tempDir, 'term_meta_bank_2.json'), JSON.stringify([]));
fs.writeFileSync(path.join(tempDir, 'term_meta_bank_3.json'), JSON.stringify([]));
fs.writeFileSync(path.join(tempDir, 'term_meta_bank_4.json'), JSON.stringify([]));
fs.writeFileSync(
path.join(tempDir, 'term_meta_bank_5.json'),
JSON.stringify([
['余り', 3, { frequency: { displayValue: 'N5' }, reading: 'あまり' }],
['私', 4, { frequency: { displayValue: 'N5' }, reading: 'わたし' }],
['私', 5, { frequency: { displayValue: 'N5' }, reading: 'わたくし' }],
]),
);
const lookup = await createJlptVocabularyLookup({
searchPaths: [tempDir],
log: (message) => {
logs.push(message);
},
});
assert.equal(lookup('余り'), 'N1');
assert.equal(lookup('私'), 'N1');
assert.equal(
logs.some((entry) => entry.includes('keeping') && entry.includes('instead')),
false,
);
assert.equal(
logs.some((entry) => entry.includes('collapsed') && entry.includes('duplicate')),
true,
);
});