chore(release): remove package size reports

- Drop the afterAllArtifactBuild size reporting hook and the previous-release baseline downloads in CI
- Stop uploading, checksumming, and publishing package-size-*.json
- Keep the afterPack package content audit, now without size tracking
- Update RELEASING.md and the verification docs, and add a changelog fragment

scripts/package-audit.cjs

@@ -4,8 +4,6 @@ const assert = require('node:assert/strict');
 const asar = require('@electron/asar');
 const { Arch } = require('builder-util');
 
-const MIB = 1024 * 1024;
-const currentReports = new Set();
 const REQUIRED_APP_FILES = [
   'package.json',
   'LICENSE',
@@ -41,13 +39,13 @@ const REQUIRED_RESOURCES = [
   'CHANGELOG.md',
 ];
 
-// Do not follow framework symlinks or count ASAR unpacked entries twice.
+// Skip symlinks when checking resource contents.
 function listFiles(root, prefix = '') {
   return fs.readdirSync(path.join(root, prefix), { withFileTypes: true }).flatMap((entry) => {
     const name = prefix ? `${prefix}/${entry.name}` : entry.name;
     if (entry.isSymbolicLink()) return [];
     if (entry.isDirectory()) return listFiles(root, name);
-    return [{ path: name, bytes: fs.statSync(path.join(root, name)).size }];
+    return [name];
   });
 }
 
@@ -58,7 +56,7 @@ function listAppFiles(archive) {
     const native = entry.replace(/^[\\/]/, '');
     const stat = asar.statFile(archive, native);
     const name = native.replaceAll('\\', '/');
-    return 'size' in stat ? [{ path: name, bytes: stat.size }] : [];
+    return 'size' in stat ? [name] : [];
   });
 }
 
@@ -99,13 +97,13 @@ function verifyAppPath(name, platform, arch) {
 
 function verifyContents(archive, resources, platform, arch) {
   const entries = listAppFiles(archive);
-  const names = new Set(entries.map((entry) => entry.path));
+  const names = new Set(entries);
   for (const name of REQUIRED_APP_FILES) assert(names.has(name), `Missing app file: ${name}`);
   for (const name of REQUIRED_RESOURCES) {
     assert(fs.statSync(path.join(resources, name)).size > 0, `Empty resource: ${name}`);
   }
   assert(listFiles(path.join(resources, 'yomitan-jlpt-vocab')).length > 0, 'Missing JLPT data');
-  for (const { path: name } of entries) verifyAppPath(name, platform, arch);
+  for (const name of entries) verifyAppPath(name, platform, arch);
   const libsqlPlatform = {
     linux: `linux-${arch}-gnu`,
     darwin: `darwin-${arch}`,
@@ -129,7 +127,7 @@ function verifyContents(archive, resources, platform, arch) {
     }
   }
   for (const name of listFiles(path.join(resources, 'assets'))) {
-    assert(!name.path.startsWith('minecard'), `Demo media shipped: ${name.path}`);
+    assert(!name.startsWith('minecard'), `Demo media shipped: ${name}`);
   }
   for (const ui of ['renderer', 'settings', 'syncui']) {
     const css = asar.extractFile(archive, path.join('dist', ui, 'style.css')).toString();
@@ -147,92 +145,8 @@ async function auditPackage(context) {
       ? path.join(context.appOutDir, `${context.packager.appInfo.productFilename}.app`)
       : context.appOutDir;
   const resources = path.join(appRoot, platform === 'darwin' ? 'Contents/Resources' : 'resources');
-  const appFiles = verifyContents(path.join(resources, 'app.asar'), resources, platform, arch);
-  const files = listFiles(appRoot);
-  const unpackedBytes = files.reduce((sum, entry) => sum + entry.bytes, 0);
-  const report = {
-    version: context.packager.appInfo.version,
-    platform,
-    arch,
-    unpackedBytes,
-    appDirectory: path.relative(context.outDir, appRoot),
-    largestFiles: [...files].sort((a, b) => b.bytes - a.bytes).slice(0, 25),
-    largestAppFiles: [...appFiles].sort((a, b) => b.bytes - a.bytes).slice(0, 25),
-    nativeBinaries: files.filter((entry) => /\.(node|dll|dylib)$|\.so(?:\.|$)/.test(entry.path)),
-    artifacts: [],
-  };
-  const output = path.join(context.outDir, `package-size-${key}.json`);
-  fs.mkdirSync(path.dirname(output), { recursive: true });
-  fs.writeFileSync(output, `${JSON.stringify(report, null, 2)}\n`);
-  currentReports.add(output);
-  console.log(
-    `Package contents verified: ${key}, ${(unpackedBytes / MIB).toFixed(2)} MiB unpacked`,
-  );
-}
-
-function artifactKind(name) {
-  if (name.endsWith('-mac.zip')) return 'mac.zip';
-  if (name.endsWith('-win.zip')) return 'win.zip';
-  const extension = path.extname(name).slice(1);
-  return ['AppImage', 'dmg', 'exe'].includes(extension) ? extension : undefined;
-}
-
-function compareSizes(report, previous) {
-  assert.equal(previous.platform, report.platform);
-  assert.equal(previous.arch, report.arch);
-  assert(Number.isFinite(previous.unpackedBytes), 'Invalid previous size report');
-  const previousArtifacts = Array.isArray(previous.artifacts) ? previous.artifacts : [];
-  return {
-    version: previous.version,
-    unpackedDeltaBytes: report.unpackedBytes - previous.unpackedBytes,
-    artifacts: report.artifacts.flatMap((artifact) => {
-      const old = previousArtifacts.find(
-        (entry) => entry && entry.kind === artifact.kind && Number.isFinite(entry.bytes),
-      );
-      return old ? [{ kind: artifact.kind, deltaBytes: artifact.bytes - old.bytes }] : [];
-    }),
-  };
-}
-
-// Runs after signing and installer creation, before release upload.
-async function afterAllArtifactBuild(result) {
-  const reports = [];
-  for (const reportPath of currentReports) {
-    const filename = path.basename(reportPath);
-    const report = JSON.parse(fs.readFileSync(reportPath, 'utf8'));
-    const key = `${report.platform}-${report.arch}`;
-    const files = listFiles(path.join(result.outDir, report.appDirectory));
-    report.unpackedBytes = files.reduce((sum, entry) => sum + entry.bytes, 0);
-    report.largestFiles = [...files].sort((a, b) => b.bytes - a.bytes).slice(0, 25);
-    report.artifacts = result.artifactPaths.flatMap((file) => {
-      const kind = artifactKind(file);
-      if (!kind) return [];
-      const bytes = fs.statSync(file).size;
-      return [{ name: path.basename(file), kind, bytes }];
-    });
-    const previousPath = path.join(result.outDir, '..', '.tmp', 'package-baseline', filename);
-    if (fs.existsSync(previousPath)) {
-      const previous = JSON.parse(fs.readFileSync(previousPath, 'utf8'));
-      report.comparison = compareSizes(report, previous);
-    }
-    fs.writeFileSync(reportPath, `${JSON.stringify(report, null, 2)}\n`);
-    const summary = [
-      `### Package size: ${key}`,
-      '',
-      `Unpacked: ${(report.unpackedBytes / MIB).toFixed(2)} MiB`,
-      ...report.artifacts.map((entry) => `${entry.name}: ${(entry.bytes / MIB).toFixed(2)} MiB`),
-      report.comparison
-        ? `Change from ${report.comparison.version}: ${(report.comparison.unpackedDeltaBytes / MIB).toFixed(2)} MiB unpacked`
-        : 'No previous size report available.',
-      '',
-    ].join('\n');
-    console.log(summary);
-    if (process.env.GITHUB_STEP_SUMMARY)
-      fs.appendFileSync(process.env.GITHUB_STEP_SUMMARY, summary);
-    reports.push(reportPath);
-  }
-  assert(reports.length > 0, 'No package size reports generated by afterPack');
-  return reports;
+  verifyContents(path.join(resources, 'app.asar'), resources, platform, arch);
+  console.log(`Package contents verified: ${key}`);
 }
 
 module.exports = {
@@ -241,6 +155,4 @@ module.exports = {
   verifyAppPath,
   listFiles,
   listAppFiles,
-  compareSizes,
-  default: afterAllArtifactBuild,
 };