sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-04-10 04:19:25 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove external command deps from fake yt-dlp shell script

Browse Source 
Replace sed with shell parameter expansion, dirname with ${var%/*},
cat heredoc with printf, and use /bin/mkdir absolute path. This
ensures the script works when PATH is empty (SUBMINER_YTDLP_BIN test).
This commit is contained in:
Kyle Yasuda
2026-04-03 13:27:55 -07:00
parent db03713a9a
commit 4dd754f826
1 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/core/services/youtube/track-download.test.ts
View File

@@ -99,7 +99,6 @@ process.exit(0);
function makeFakeYtDlpShellScript(dir: string): string { function makeFakeYtDlpShellScript(dir: string): string {
const scriptPath = path.join(dir, 'yt-dlp'); const scriptPath = path.join(dir, 'yt-dlp');
const script = `#!/bin/sh const script = `#!/bin/sh
PATH=/usr/bin:/bin:/usr/local/bin
has_auto_subs=0 has_auto_subs=0
wants_auto_subs=0 wants_auto_subs=0
wants_manual_subs=0 wants_manual_subs=0
@@ -136,11 +135,12 @@ if [ -n "$YTDLP_EXPECT_SUB_LANG" ] && [ "$sub_lang" != "$YTDLP_EXPECT_SUB_LANG"
exit 4 exit 4
fi fi
prefix="$(printf '%s' "$output_template" | sed 's/\.%(ext)s$//')" prefix="\${output_template%.%(ext)s}"
if [ -z "$prefix" ]; then if [ -z "$prefix" ]; then
exit 1 exit 1
fi fi
mkdir -p "$(dirname \"$prefix\")" dir="\${prefix%/*}"
[ -d "$dir" ] || /bin/mkdir -p "$dir"
if [ "$YTDLP_FAKE_MODE" = "multi" ]; then if [ "$YTDLP_FAKE_MODE" = "multi" ]; then
OLD_IFS="$IFS" OLD_IFS="$IFS"
@@ -152,18 +152,7 @@ if [ "$YTDLP_FAKE_MODE" = "multi" ]; then
done done
IFS="$OLD_IFS" IFS="$OLD_IFS"
elif [ "$YTDLP_FAKE_MODE" = "rolling-auto" ]; then elif [ "$YTDLP_FAKE_MODE" = "rolling-auto" ]; then
cat <<'EOF' > "\${prefix}.vtt" printf 'WEBVTT\\n\\n00:00:01.000 --> 00:00:02.000\\n今日は\\n\\n00:00:02.000 --> 00:00:03.000\\n今日はいい天気ですね\\n\\n00:00:03.000 --> 00:00:04.000\\n今日はいい天気ですね本当に\\n' > "\${prefix}.vtt"
WEBVTT
00:00:01.000 --> 00:00:02.000
今日は
00:00:02.000 --> 00:00:03.000
今日はいい天気ですね
00:00:03.000 --> 00:00:04.000
今日はいい天気ですね本当に
EOF
elif [ "$YTDLP_FAKE_MODE" = "multi-primary-only-fail" ]; then elif [ "$YTDLP_FAKE_MODE" = "multi-primary-only-fail" ]; then
primary_lang="\${sub_lang%%,*}" primary_lang="\${sub_lang%%,*}"
if [ -n "$primary_lang" ]; then if [ -n "$primary_lang" ]; then