sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-08-08 07:21:31 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(anime): isolate mark-watched requests and batch marks atomically

Browse Source 
- Track mark writes with their own LatestRequest so a concurrent watch-state
  refresh can't supersede them, and re-read the store after a write to settle
  stale repaints
- Wrap batch markEpisodesWatched in a single transaction so partial rows and
  their lifetime summary rebuild can't land separately; defer clearing the
  active session's markedWatched flag until after commit
This commit is contained in:
Kyle Yasuda
2026-08-03 02:10:10 -07:00
parent 7db247ef5b
commit 4c6bfaa22e
2 changed files with 42 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/services/immersion-tracker-service.ts
+31 -18
View File
@@ -30,6 +30,7 @@ import {
applySessionLifetimeSummary,
reconcileStaleActiveSessions,
rebuildLifetimeSummaries as rebuildLifetimeSummaryTables,
rebuildLifetimeSummariesInTransaction,
shouldBackfillLifetimeSummaries,
} from './immersion-tracker/lifetime';
import {
@@ -755,28 +756,40 @@ export class ImmersionTrackerService {
// Every row this creates would otherwise rebuild the lifetime summaries on
// its own, and a season's worth of episodes arrives in one call.
let needsLifetimeRebuild = false;
for (const episode of episodes) {
const statsPath = normalizeMediaPath(episode.statsPath);
if (!statsPath) continue;
if (watched) {
needsLifetimeRebuild =
this.recordStreamPlaybackMetadata(episode, { deferLifetimeRebuild: true }) ||
needsLifetimeRebuild;
// A half-applied batch would leave rows created without their marks, so the
// whole span of episodes and the summary rebuild land together or not at all.
let clearedActiveVideo = false;
this.db.exec('BEGIN IMMEDIATE');
try {
for (const episode of episodes) {
const statsPath = normalizeMediaPath(episode.statsPath);
if (!statsPath) continue;
if (watched) {
needsLifetimeRebuild =
this.recordStreamPlaybackMetadata(episode, { deferLifetimeRebuild: true }) ||
needsLifetimeRebuild;
}
const videoId = getVideoIdByVideoKey(this.db, buildVideoKey(statsPath, SOURCE_TYPE_REMOTE));
if (videoId === null) continue;
markVideoWatched(this.db, videoId, watched);
changed += 1;
if (!watched && this.sessionState?.videoId === videoId) clearedActiveVideo = true;
}
const videoId = getVideoIdByVideoKey(this.db, buildVideoKey(statsPath, SOURCE_TYPE_REMOTE));
if (videoId === null) continue;
markVideoWatched(this.db, videoId, watched);
changed += 1;
// Clearing the mark on what is playing right now would otherwise be undone
// the moment the session passes the completion threshold again.
if (!watched && this.sessionState?.videoId === videoId) {
this.sessionState.markedWatched = true;
}
if (needsLifetimeRebuild) rebuildLifetimeSummariesInTransaction(this.db);
this.db.exec('COMMIT');
} catch (error) {
this.db.exec('ROLLBACK');
throw error;
}
if (needsLifetimeRebuild) rebuildLifetimeSummaryTables(this.db);
// Clearing the mark on what is playing right now would otherwise be undone
// the moment the session passes the completion threshold again. Set after the
// commit, so a rolled back clear does not suppress the automatic mark.
if (clearedActiveVideo && this.sessionState) this.sessionState.markedWatched = true;
return changed;
}