sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-22 12:11:27 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(subtitle-sidebar): address CodeRabbit follow-ups

Browse Source
This commit is contained in:
Kyle Yasuda
2026-03-21 20:49:44 -07:00
parent a42fe599cb
commit 45d183d02d
4 changed files with 39 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backlog/tasks/task-216 - Address-PR-28-CodeRabbit-follow-ups-on-subtitle-sidebar.md
View File

@@ -5,7 +5,7 @@ status: In Progress
assignee:
- '@codex'
created_date: '2026-03-21 00:00'
updated_date: '2026-03-22 02:34'
updated_date: '2026-03-22 03:26'
labels:
- pr-review
- subtitle-sidebar
@@ -60,6 +60,8 @@ Verification:
2026-03-21: Addressed the latest CodeRabbit follow-up pass in commit d70c6448 after rebasing onto the updated remote branch tip.
2026-03-21: Reopened for the latest CodeRabbit round on commit d70c6448; current actionable item is the invalid ctx.state.isOverSubtitleSidebar assignment in subtitle-sidebar.ts.
2026-03-22: Addressed the live hover-state and startup mouse-ignore follow-ups from the latest CodeRabbit pass. `handleMouseLeave()` now clears `isOverSubtitle` and drops `secondary-sub-hover-active` when leaving the secondary subtitle container toward the primary container, and renderer startup now calls `syncOverlayMouseIgnoreState(ctx)` instead of forcing `setIgnoreMouseEvents(true, { forward: true })`. The sidebar IPC hover catch and CSS spacing comments were already satisfied in the current tree.
<!-- SECTION:NOTES:END -->
## Final Summary