mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-11-18 04:46:07 -08:00
fix(anki): hold playback paused while media timing review is open
- Defer overlay resume requests (popup closed, hover left) during an active review and apply them when the review closes - Add deferPlaybackResume to the media timing review runtime and gate sendRendererMpvCommand on it - Document the paused-playback behavior and add a changelog fragment
This commit is contained in:
5 files changed
+72
-3
No files matched your search
@@ -283,6 +283,7 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
let active: ActiveReview | null = null;
|
||||
let currentRequest: ReviewRequestLifecycle | null = null;
|
||||
let pendingPauseRestore: ReviewMpvClient | null = null;
|
||||
let resumeDeferred = false;
|
||||
|
||||
function restorePendingPlayback(): void {
|
||||
const mpvClient = pendingPauseRestore;
|
||||
@@ -292,6 +293,26 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
}
|
||||
}
|
||||
|
||||
function resumeDeferredPlayback(): void {
|
||||
if (!resumeDeferred) return;
|
||||
resumeDeferred = false;
|
||||
const mpvClient = deps.getMpvClient();
|
||||
if (mpvClient?.connected) {
|
||||
mpvClient.send({ command: ['set_property', 'pause', 'no'] });
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Holds an overlay request to resume playback (e.g. an auto-pause released because the
|
||||
* dictionary popup closed) until the pending review ends, then applies it. Returns false
|
||||
* when no review holds playback, so the caller should resume right away.
|
||||
*/
|
||||
function deferPlaybackResume(): boolean {
|
||||
if (!active && !currentRequest) return false;
|
||||
resumeDeferred = true;
|
||||
return true;
|
||||
}
|
||||
|
||||
function ensureWindow(
|
||||
review: ActiveReview,
|
||||
range: RemoteMediaWindowRange,
|
||||
@@ -539,6 +560,7 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
} finally {
|
||||
if (currentRequest === lifecycle) {
|
||||
currentRequest = null;
|
||||
resumeDeferredPlayback();
|
||||
}
|
||||
lifecycle.markSettled();
|
||||
}
|
||||
@@ -737,7 +759,8 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
if (!current) return;
|
||||
deps.clearFrameCache?.();
|
||||
void current.preview?.session.then((session) => session.dispose()).catch(() => {});
|
||||
if (current.restorePlayback && current.mpvClient.connected) {
|
||||
if ((current.restorePlayback || resumeDeferred) && current.mpvClient.connected) {
|
||||
resumeDeferred = false;
|
||||
current.mpvClient.send({ command: ['set_property', 'pause', 'no'] });
|
||||
}
|
||||
}
|
||||
@@ -758,6 +781,7 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
getFrame,
|
||||
stopPreview,
|
||||
resolveReview,
|
||||
deferPlaybackResume,
|
||||
dispose,
|
||||
};
|
||||
}
|
||||
Reference in new issue
Block a user