sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-05-29 12:55:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: include audio padding in animated AVIF source range (#94)

Browse Source
This commit is contained in:
Kyle Yasuda
2026-05-27 14:06:48 -07:00
committed by GitHub
parent f033f87329
commit 3e6591e390
7 changed files with 21 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config/definitions/options-integrations.ts
+2 -1
View File
@@ -246,7 +246,8 @@ export function buildIntegrationConfigOptionRegistry(
path: 'ankiConnect.media.audioPadding',
kind: 'number',
defaultValue: defaultConfig.ankiConnect.media.audioPadding,
description: 'Seconds of padding appended to both ends of generated sentence audio.',
description:
'Seconds of padding appended to both ends of generated sentence audio and animated AVIF clips.',
},
{
path: 'ankiConnect.media.fallbackDuration',
src/media-generator.test.ts
+12 -18
View File
@@ -67,7 +67,7 @@ test('buildAnimatedImageVideoFilter prepends a cloned first frame when lead-in i
);
});
test('generateAnimatedImage freezes first frame for leading audio padding', async () => {
test('generateAnimatedImage includes leading audio padding in the source range', async () => {
await withStubbedFfmpeg(async (generator, argsPath) => {
await generator.generateAnimatedImage('/video.mp4', 10, 12, 0.5, {
fps: 10,
@@ -75,12 +75,9 @@ test('generateAnimatedImage freezes first frame for leading audio padding', asyn
});
const args = readFfmpegArgs(argsPath);
assert.equal(args[args.indexOf('-ss') + 1], '10');
assert.equal(args[args.indexOf('-t') + 1], '2.5');
assert.equal(
args[args.indexOf('-vf') + 1],
'tpad=start_duration=0.5:start_mode=clone,fps=10,scale=w=640:h=-2',
);
assert.equal(args[args.indexOf('-ss') + 1], '9.5');
assert.equal(args[args.indexOf('-t') + 1], '3');
assert.equal(args[args.indexOf('-vf') + 1], 'fps=10,scale=w=640:h=-2');
});
});
@@ -98,7 +95,7 @@ test('generateAnimatedImage defaults to unpadded sentence timing', async () => {
});
});
test('generateAnimatedImage adds audio lead padding to existing word-audio lead-in', async () => {
test('generateAnimatedImage keeps word-audio lead-in separate from audio padding', async () => {
await withStubbedFfmpeg(async (generator, argsPath) => {
await generator.generateAnimatedImage('/video.mp4', 10, 12, 0.5, {
fps: 10,
@@ -107,16 +104,16 @@ test('generateAnimatedImage adds audio lead padding to existing word-audio lead-
});
const args = readFfmpegArgs(argsPath);
assert.equal(args[args.indexOf('-ss') + 1], '10');
assert.equal(args[args.indexOf('-t') + 1], '2.5');
assert.equal(args[args.indexOf('-ss') + 1], '9.5');
assert.equal(args[args.indexOf('-t') + 1], '3');
assert.equal(
args[args.indexOf('-vf') + 1],
'tpad=start_duration=1.75:start_mode=clone,fps=10,scale=w=640:h=-2',
'tpad=start_duration=1.25:start_mode=clone,fps=10,scale=w=640:h=-2',
);
});
});
test('generateAnimatedImage clips leading audio padding at the start of media', async () => {
test('generateAnimatedImage clips padded source range at the start of media', async () => {
await withStubbedFfmpeg(async (generator, argsPath) => {
await generator.generateAnimatedImage('/video.mp4', 0.2, 1.2, 0.5, {
fps: 10,
@@ -124,12 +121,9 @@ test('generateAnimatedImage clips leading audio padding at the start of media',
});
const args = readFfmpegArgs(argsPath);
assert.equal(args[args.indexOf('-ss') + 1], '0.2');
assert.equal(args[args.indexOf('-t') + 1], '1.5');
assert.equal(
args[args.indexOf('-vf') + 1],
'tpad=start_duration=0.2:start_mode=clone,fps=10,scale=w=640:h=-2',
);
assert.equal(args[args.indexOf('-ss') + 1], '0');
assert.equal(args[args.indexOf('-t') + 1], '1.7');
assert.equal(args[args.indexOf('-vf') + 1], 'fps=10,scale=w=640:h=-2');
});
});
src/media-generator.ts
+3 -4
View File
@@ -322,10 +322,9 @@ export class MediaGenerator {
): Promise<Buffer> {
const { fps = 10, maxWidth = 640, maxHeight, crf = 35, leadingStillDuration = 0 } = options;
const safePadding = Number.isFinite(padding) ? Math.max(0, padding) : 0;
const start = Math.max(0, startTime);
const duration = endTime - startTime + safePadding;
const effectiveLeadingPadding = Math.min(safePadding, start);
const totalLeadingStillDuration = Math.max(0, leadingStillDuration) + effectiveLeadingPadding;
const start = Math.max(0, startTime - safePadding);
const duration = endTime - start + safePadding;
const totalLeadingStillDuration = Math.max(0, leadingStillDuration);
const clampedCrf = Math.max(0, Math.min(63, crf));