mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-11-18 04:46:07 -08:00
fix(anki): keep playback paused after overlay pause during timing review
- Treat overlay pause requests during an open media timing review as final: drop held resumes and the review's own playback restore - Add cancelPlaybackResume to the media timing review runtime - Test both paused and playing starting states
This commit is contained in:
3 files changed
+41
-9
No files matched your search
@@ -313,6 +313,15 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* The overlay asked to pause while a review holds playback, so closing the review must
|
||||
* not resume it: drops both a held overlay resume and the review's own restore.
|
||||
*/
|
||||
function cancelPlaybackResume(): void {
|
||||
resumeDeferred = false;
|
||||
if (active) active.restorePlayback = false;
|
||||
}
|
||||
|
||||
function ensureWindow(
|
||||
review: ActiveReview,
|
||||
range: RemoteMediaWindowRange,
|
||||
@@ -782,6 +791,7 @@ export function createMediaTimingReviewRuntime(deps: MediaTimingReviewRuntimeDep
|
||||
stopPreview,
|
||||
resolveReview,
|
||||
deferPlaybackResume,
|
||||
cancelPlaybackResume,
|
||||
dispose,
|
||||
};
|
||||
}
|
||||
Reference in new issue
Block a user