refactor: extract app-ready startup orchestration service

src/core/services/app-ready-runtime-service.test.ts

@@ -0,0 +1,57 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { AppReadyRuntimeDeps, runAppReadyRuntimeService } from "./app-ready-runtime-service";
+
+function makeDeps(overrides: Partial<AppReadyRuntimeDeps> = {}) {
+  const calls: string[] = [];
+  const deps: AppReadyRuntimeDeps = {
+    loadSubtitlePosition: () => calls.push("loadSubtitlePosition"),
+    resolveKeybindings: () => calls.push("resolveKeybindings"),
+    createMpvClient: () => calls.push("createMpvClient"),
+    reloadConfig: () => calls.push("reloadConfig"),
+    getResolvedConfig: () => ({ websocket: { enabled: "auto" }, secondarySub: {} }),
+    getConfigWarnings: () => [],
+    logConfigWarning: () => calls.push("logConfigWarning"),
+    initRuntimeOptionsManager: () => calls.push("initRuntimeOptionsManager"),
+    setSecondarySubMode: (mode) => calls.push(`setSecondarySubMode:${mode}`),
+    defaultSecondarySubMode: "hover",
+    defaultWebsocketPort: 9001,
+    hasMpvWebsocketPlugin: () => true,
+    startSubtitleWebsocket: (port) => calls.push(`startSubtitleWebsocket:${port}`),
+    log: (message) => calls.push(`log:${message}`),
+    createMecabTokenizerAndCheck: async () => {
+      calls.push("createMecabTokenizerAndCheck");
+    },
+    createSubtitleTimingTracker: () => calls.push("createSubtitleTimingTracker"),
+    loadYomitanExtension: async () => {
+      calls.push("loadYomitanExtension");
+    },
+    texthookerOnlyMode: false,
+    shouldAutoInitializeOverlayRuntimeFromConfig: () => true,
+    initializeOverlayRuntime: () => calls.push("initializeOverlayRuntime"),
+    handleInitialArgs: () => calls.push("handleInitialArgs"),
+    ...overrides,
+  };
+  return { deps, calls };
+}
+
+test("runAppReadyRuntimeService starts websocket in auto mode when plugin missing", async () => {
+  const { deps, calls } = makeDeps({
+    hasMpvWebsocketPlugin: () => false,
+  });
+  await runAppReadyRuntimeService(deps);
+  assert.ok(calls.includes("startSubtitleWebsocket:9001"));
+  assert.ok(calls.includes("initializeOverlayRuntime"));
+});
+
+test("runAppReadyRuntimeService logs defer message when overlay not auto-started", async () => {
+  const { deps, calls } = makeDeps({
+    shouldAutoInitializeOverlayRuntimeFromConfig: () => false,
+  });
+  await runAppReadyRuntimeService(deps);
+  assert.ok(
+    calls.includes(
+      "log:Overlay runtime deferred: waiting for explicit overlay command.",
+    ),
+  );
+});

src/core/services/app-ready-runtime-service.ts

@@ -0,0 +1,77 @@
+import { ConfigValidationWarning, SecondarySubMode } from "../../types";
+
+interface AppReadyConfigLike {
+  secondarySub?: {
+    defaultMode?: SecondarySubMode;
+  };
+  websocket?: {
+    enabled?: boolean | "auto";
+    port?: number;
+  };
+}
+
+export interface AppReadyRuntimeDeps {
+  loadSubtitlePosition: () => void;
+  resolveKeybindings: () => void;
+  createMpvClient: () => void;
+  reloadConfig: () => void;
+  getResolvedConfig: () => AppReadyConfigLike;
+  getConfigWarnings: () => ConfigValidationWarning[];
+  logConfigWarning: (warning: ConfigValidationWarning) => void;
+  initRuntimeOptionsManager: () => void;
+  setSecondarySubMode: (mode: SecondarySubMode) => void;
+  defaultSecondarySubMode: SecondarySubMode;
+  defaultWebsocketPort: number;
+  hasMpvWebsocketPlugin: () => boolean;
+  startSubtitleWebsocket: (port: number) => void;
+  log: (message: string) => void;
+  createMecabTokenizerAndCheck: () => Promise<void>;
+  createSubtitleTimingTracker: () => void;
+  loadYomitanExtension: () => Promise<void>;
+  texthookerOnlyMode: boolean;
+  shouldAutoInitializeOverlayRuntimeFromConfig: () => boolean;
+  initializeOverlayRuntime: () => void;
+  handleInitialArgs: () => void;
+}
+
+export async function runAppReadyRuntimeService(
+  deps: AppReadyRuntimeDeps,
+): Promise<void> {
+  deps.loadSubtitlePosition();
+  deps.resolveKeybindings();
+  deps.createMpvClient();
+
+  deps.reloadConfig();
+  const config = deps.getResolvedConfig();
+  for (const warning of deps.getConfigWarnings()) {
+    deps.logConfigWarning(warning);
+  }
+  deps.initRuntimeOptionsManager();
+  deps.setSecondarySubMode(
+    config.secondarySub?.defaultMode ?? deps.defaultSecondarySubMode,
+  );
+
+  const wsConfig = config.websocket || {};
+  const wsEnabled = wsConfig.enabled ?? "auto";
+  const wsPort = wsConfig.port || deps.defaultWebsocketPort;
+
+  if (wsEnabled === true || (wsEnabled === "auto" && !deps.hasMpvWebsocketPlugin())) {
+    deps.startSubtitleWebsocket(wsPort);
+  } else if (wsEnabled === "auto") {
+    deps.log("mpv_websocket detected, skipping built-in WebSocket server");
+  }
+
+  await deps.createMecabTokenizerAndCheck();
+  deps.createSubtitleTimingTracker();
+  await deps.loadYomitanExtension();
+
+  if (deps.texthookerOnlyMode) {
+    deps.log("Texthooker-only mode enabled; skipping overlay window.");
+  } else if (deps.shouldAutoInitializeOverlayRuntimeFromConfig()) {
+    deps.initializeOverlayRuntime();
+  } else {
+    deps.log("Overlay runtime deferred: waiting for explicit overlay command.");
+  }
+
+  deps.handleInitialArgs();
+}