Fix overlay toggle regression TASK-7

This commit is contained in:
2026-02-21 23:47:34 -08:00
parent 44c7b05f96
commit 26c031aea8
8 changed files with 152 additions and 6 deletions

View File

@@ -68,3 +68,4 @@ Read first. Keep concise.
| `codex-fix-rebase-errors-20260222T062235Z-73h4` | `codex-fix-rebase-errors` | `Resolve current git rebase conflicts in ipc/main runtime files and land clean rebase state` | `done` | `docs/subagents/agents/codex-fix-rebase-errors-20260222T062235Z-73h4.md` | `2026-02-22T06:30:48Z` |
| `codex-review-cleanup-20260222T065718Z-9p4m` | `codex-review-cleanup` | `Review post-refactor codebase quality and create cleanup tickets with concrete scope and completion criteria` | `done` | `docs/subagents/agents/codex-review-cleanup-20260222T065718Z-9p4m.md` | `2026-02-22T07:04:48Z` |
| `codex-jellyfin-ts-fix-20260222T071530Z-5e50` | `codex-jellyfin-ts-fix` | `Fix Jellyfin token/session type drift causing TS compile failures in config+main.` | `done` | `docs/subagents/agents/codex-jellyfin-ts-fix-20260222T071530Z-5e50.md` | `2026-02-22T07:23:47Z` |
| `codex-overlay-toggle-regression-20260222T073450Z-q7m4` | `codex-overlay-toggle-regression` | `Fix post-rebase overlay toggle regression causing transparent non-interactable windows and broken keybinds (TASK-107).` | `testing` | `docs/subagents/agents/codex-overlay-toggle-regression-20260222T073450Z-q7m4.md` | `2026-02-22T07:45:58Z` |

View File

@@ -0,0 +1,33 @@
# Agent: `codex-overlay-toggle-regression-20260222T073450Z-q7m4`
- alias: `codex-overlay-toggle-regression`
- mission: `Fix post-rebase overlay toggle regression causing transparent non-interactable windows and broken keybinds (TASK-107).`
- status: `testing`
- branch: `main`
- started_at: `2026-02-22T07:34:50Z`
- heartbeat_minutes: `5`
## Current Work (newest first)
- [2026-02-22T07:45:58Z] progress: Added `src/core/services/overlay-window-config.test.ts` red test for explicit `webPreferences.sandbox=false`; patched `src/core/services/overlay-window.ts` with `sandbox: false`; verified focused tests + full build pass.
- [2026-02-22T07:44:40Z] test: Added red regression in `src/renderer/error-recovery.test.ts` proving `resolvePlatformInfo` incorrectly preferred preload layer over query layer; patched `src/renderer/utils/platform.ts` to prioritize `?layer=` and reran tests/build green.
- [2026-02-22T07:34:50Z] intent: Initialize session record, associate work with TASK-107, inspect overlay runtime + renderer regressions after rebase.
## Files Touched
- `backlog/tasks/task-107 - Fix-post-rebase-overlay-toggle-regression.md`
- `docs/subagents/agents/codex-overlay-toggle-regression-20260222T073450Z-q7m4.md`
- `docs/subagents/INDEX.md`
- `docs/subagents/collaboration.md`
- `src/renderer/error-recovery.test.ts`
- `src/renderer/utils/platform.ts`
- `src/core/services/overlay-window.ts`
- `src/core/services/overlay-window-config.test.ts`
## Assumptions
- Regression likely introduced by recent rebase merge in main/runtime overlay wiring.
- Existing overlay regression tests can be extended for red-green fix.
## Open Questions / Blockers
- Exact break location (window options vs renderer preload/load path vs toggle handler state).
## Next Step
- Hand off fix summary + validation commands to user for runtime confirmation on host machine.

View File

@@ -98,3 +98,6 @@ Shared notes. Append-only.
- [2026-02-22T07:15:30Z] [codex-jellyfin-ts-fix-20260222T071530Z-5e50|codex-jellyfin-ts-fix] overlap note: fixing Jellyfin config/runtime type drift touching `src/main.ts`, `src/config/definitions/*`, `src/config/resolve/*`; preserving recent refactor structure and limiting scope to TS errors only.
- [2026-02-22T07:18:07Z] [codex-jellyfin-ts-fix-20260222T071530Z-5e50|codex-jellyfin-ts-fix] completed TS fix: removed legacy `jellyfin.accessToken/userId` from defaults/resolver, aligned `src/main.ts` to `loadSession/saveSession/clearSession`, added resolver regression test for legacy keys, and verified `bun run tsc --noEmit` + focused jellyfin tests green.
- [2026-02-22T07:23:47Z] [codex-jellyfin-ts-fix-20260222T071530Z-5e50|codex-jellyfin-ts-fix] docs follow-up: fixed stale `docs/configuration.md` Jellyfin table/text to remove `accessToken/userId` config guidance; now states stored encrypted session + env override keys.
- [2026-02-22T07:34:50Z] [codex-overlay-toggle-regression-20260222T073450Z-q7m4|codex-overlay-toggle-regression] starting TASK-107 bugfix for post-rebase overlay regression: toggling visible/invisible opens transparent non-interactable window; keybinds + subtitle rendering fail in both modes.
- [2026-02-22T07:44:40Z] [codex-overlay-toggle-regression-20260222T073450Z-q7m4|codex-overlay-toggle-regression] identified renderer layer-resolution bug risk under shared renderer process (`process.argv` preload arg drift); fixed `resolvePlatformInfo` to prioritize per-window `?layer=` query, added regression test, verified `bun test src/renderer/error-recovery.test.ts` + `bun run build`.
- [2026-02-22T07:45:58Z] [codex-overlay-toggle-regression-20260222T073450Z-q7m4|codex-overlay-toggle-regression] added explicit overlay BrowserWindow sandbox guard (`webPreferences.sandbox=false`) to avoid preload API break on newer Electron defaults; added regression test `src/core/services/overlay-window-config.test.ts`; verified focused tests + build green.