sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-04-12 04:19:25 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CodeRabbit review round 3

Browse Source
This commit is contained in:
Kyle Yasuda
2026-04-10 18:57:49 -07:00
committed by sudacode
parent 735fc26525
commit 18940b57c0
16 changed files with 305 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugin/subminer/session_bindings.lua
View File

@@ -89,13 +89,20 @@ function M.create(ctx)
return nil
end
if type(key.code) ~= "string" then
return nil
end
if type(key.modifiers) ~= "table" then
return nil
end
local key_name = key_code_to_mpv_name(key.code)
if not key_name then
return nil
end
local parts = {}
for _, modifier in ipairs(key.modifiers or {}) do
for _, modifier in ipairs(key.modifiers) do
local mapped = MODIFIER_MAP[modifier]
if mapped then
parts[#parts + 1] = mapped
@@ -298,7 +305,6 @@ function M.create(ctx)
local previous_binding_names = state.session_binding_names
local next_binding_names = {}
state.session_binding_names = next_binding_names
local timeout_ms = tonumber(artifact.numericSelectionTimeoutMs) or 3000
for index, binding in ipairs(artifact.bindings) do
@@ -319,6 +325,7 @@ function M.create(ctx)
end
remove_binding_names(previous_binding_names)
state.session_binding_names = next_binding_names
subminer_log(
"info",