sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-21 12:11:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(subtitle): improve frequency highlight reliability

Browse Source
This commit is contained in:
Kyle Yasuda
2026-03-01 20:12:42 -08:00
parent 68e5a7fef3
commit 17a417e639
4 changed files with 161 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/subtitle-render.test.ts
View File

@@ -79,7 +79,7 @@ test('computeWordClass preserves known and n+1 classes while adding JLPT classes
assert.equal(computeWordClass(nPlusOneJlpt), 'word word-n-plus-one word-jlpt-n2');
});
test('computeWordClass keeps known/N+1 color classes exclusive over frequency classes', () => {
test('computeWordClass composes known class with frequency class while keeping N+1 exclusive', () => {
const known = createToken({
isKnown: true,
frequencyRank: 10,
@@ -103,7 +103,7 @@ test('computeWordClass keeps known/N+1 color classes exclusive over frequency cl
singleColor: '#000000',
bandedColors: ['#000000', '#000000', '#000000', '#000000', '#000000'] as const,
}),
'word word-known',
'word word-known word-frequency-single',
);
assert.equal(
computeWordClass(nPlusOne, {

2
src/renderer/subtitle-render.ts
View File

@@ -429,7 +429,7 @@ export function computeWordClass(
classes.push(`word-jlpt-${token.jlptLevel.toLowerCase()}`);
}
if (!token.isKnown && !token.isNPlusOneTarget) {
if (!token.isNPlusOneTarget) {
const frequencyClass = getFrequencyDictionaryClass(token, resolvedFrequencySettings);
if (frequencyClass) {
classes.push(frequencyClass);