feat(notifications): add overlay notifications with position config

- Add Catppuccin Macchiato overlay notification stack with 3s transient timeout - Add `notifications.overlayPosition` config (top-left | top | top-right) - Route startup tokenization and subtitle annotation status through configured surfaces - Deduplicate rapid subtitle mode toggle notifications - Change `both` to mean overlay + system; add `osd-system` as legacy alias for old behavior - Keep `osd`/`osd-system` as config-file-only legacy values; Settings UI offers overlay/system/both/none
2026-06-10 15:13:32 -07:00 · 2026-06-04 21:56:51 -07:00
parent c09d009a3e
commit 144373db52
82 changed files with 2290 additions and 243 deletions
@@ -0,0 +1,174 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import {
+  getPlaybackFeedbackNotificationOptions,
+  notifyConfiguredStatus,
+} from './configured-status-notification';
+
+test('notifyConfiguredStatus routes both to overlay and system without osd', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus('Subsync: choose engine and source', {
+    getNotificationType: () => 'both',
+    showOsd: (message) => {
+      calls.push(`osd:${message}`);
+    },
+    showOverlayNotification: (payload) =>
+      calls.push(
+        `overlay:${payload.id ?? ''}:${payload.title}:${payload.body}:${payload.variant}:${payload.persistent ? 'pin' : 'auto'}`,
+      ),
+    showDesktopNotification: (title, options) =>
+      calls.push(`desktop:${title}:${options.body ?? ''}`),
+  });
+
+  assert.deepEqual(calls, [
+    'overlay::SubMiner:Subsync: choose engine and source:info:auto',
+    'desktop:SubMiner:Subsync: choose engine and source',
+  ]);
+});
+
+test('notifyConfiguredStatus routes pre-overlay status to osd only', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus('Overlay loading...', {
+    getNotificationType: () => 'both',
+    isOverlayReady: () => false,
+    showOsd: (message) => {
+      calls.push(`osd:${message}`);
+    },
+    showOverlayNotification: (payload) =>
+      calls.push(`overlay:${payload.id ?? ''}:${payload.body ?? ''}`),
+    showDesktopNotification: (title, options) =>
+      calls.push(`desktop:${title}:${options.body ?? ''}`),
+  });
+
+  assert.deepEqual(calls, ['osd:Overlay loading...']);
+});
+
+test('notifyConfiguredStatus keeps osd-system on legacy surfaces', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus('Overlay loading...', {
+    getNotificationType: () => 'osd-system',
+    showOsd: (message) => {
+      calls.push(`osd:${message}`);
+    },
+    showDesktopNotification: (title, options) =>
+      calls.push(`desktop:${title}:${options.body ?? ''}`),
+  });
+
+  assert.deepEqual(calls, ['osd:Overlay loading...', 'desktop:SubMiner:Overlay loading...']);
+});
+
+test('notifyConfiguredStatus can suppress desktop delivery for progress ticks', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus(
+    'Subsync: syncing |',
+    {
+      getNotificationType: () => 'both',
+      showOsd: (message) => {
+        calls.push(`osd:${message}`);
+      },
+      showOverlayNotification: (payload) =>
+        calls.push(
+          `overlay:${payload.id ?? ''}:${payload.title}:${payload.body}:${payload.variant}:${payload.persistent ? 'pin' : 'auto'}`,
+        ),
+      showDesktopNotification: (title, options) =>
+        calls.push(`desktop:${title}:${options.body ?? ''}`),
+    },
+    {
+      id: 'subsync-status',
+      title: 'Subsync',
+      variant: 'progress',
+      persistent: true,
+      desktop: false,
+    },
+  );
+
+  assert.deepEqual(calls, ['overlay:subsync-status:Subsync:Subsync: syncing |:progress:pin']);
+});
+
+test('notifyConfiguredStatus routes feedback through overlay without desktop delivery', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus(
+    'Primary subtitle: hover',
+    {
+      getNotificationType: () => 'both',
+      showOsd: (message) => {
+        calls.push(`osd:${message}`);
+      },
+      showOverlayNotification: (payload) =>
+        calls.push(`overlay:${payload.title}:${payload.body ?? ''}`),
+      showDesktopNotification: (title, options) =>
+        calls.push(`desktop:${title}:${options.body ?? ''}`),
+    },
+    { delivery: 'feedback' },
+  );
+
+  assert.deepEqual(calls, ['overlay:SubMiner:Primary subtitle: hover']);
+});
+
+test('notifyConfiguredStatus routes osd-system feedback through osd only', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus(
+    'Secondary subtitle: visible',
+    {
+      getNotificationType: () => 'osd-system',
+      showOsd: (message) => {
+        calls.push(`osd:${message}`);
+      },
+      showDesktopNotification: (title, options) =>
+        calls.push(`desktop:${title}:${options.body ?? ''}`),
+    },
+    { delivery: 'feedback' },
+  );
+
+  assert.deepEqual(calls, ['osd:Secondary subtitle: visible']);
+});
+
+test('notifyConfiguredStatus suppresses system-only feedback', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus(
+    'Primary subtitle: visible',
+    {
+      getNotificationType: () => 'system',
+      showOsd: (message) => {
+        calls.push(`osd:${message}`);
+      },
+      showDesktopNotification: (title, options) =>
+        calls.push(`desktop:${title}:${options.body ?? ''}`),
+    },
+    { delivery: 'feedback' },
+  );
+
+  assert.deepEqual(calls, []);
+});
+
+test('playback feedback options reuse subtitle mode notification ids', () => {
+  assert.deepEqual(getPlaybackFeedbackNotificationOptions('Primary subtitle: hover'), {
+    id: 'primary-subtitle-mode-feedback',
+  });
+  assert.deepEqual(getPlaybackFeedbackNotificationOptions('Secondary subtitle: hidden'), {
+    id: 'secondary-subtitle-mode-feedback',
+  });
+  assert.deepEqual(getPlaybackFeedbackNotificationOptions('Secondary subtitle track: English'), {});
+});
+
+test('notifyConfiguredStatus falls back to desktop if overlay is unavailable', () => {
+  const calls: string[] = [];
+
+  notifyConfiguredStatus('Overlay unavailable.', {
+    getNotificationType: () => 'overlay',
+    showOsd: (message) => {
+      calls.push(`osd:${message}`);
+    },
+    showDesktopNotification: (title, options) =>
+      calls.push(`desktop:${title}:${options.body ?? ''}`),
+  });
+
+  assert.deepEqual(calls, ['desktop:SubMiner:Overlay unavailable.']);
+});