refactor: extract field grouping overlay runtime service

src/core/services/field-grouping-overlay-runtime-service.test.ts

@@ -0,0 +1,82 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { KikuFieldGroupingChoice } from "../../types";
+import { createFieldGroupingOverlayRuntimeService } from "./field-grouping-overlay-runtime-service";
+
+test("createFieldGroupingOverlayRuntimeService sends overlay messages and sets restore flag", () => {
+  const sent: unknown[][] = [];
+  let visible = false;
+  const restore = new Set<"runtime-options" | "subsync">();
+
+  const runtime =
+    createFieldGroupingOverlayRuntimeService<"runtime-options" | "subsync">({
+    getMainWindow: () => ({
+      isDestroyed: () => false,
+      webContents: {
+        send: (...args: unknown[]) => {
+          sent.push(args);
+        },
+      },
+    }),
+    getVisibleOverlayVisible: () => visible,
+    getInvisibleOverlayVisible: () => false,
+    setVisibleOverlayVisible: (next) => {
+      visible = next;
+    },
+    setInvisibleOverlayVisible: () => {},
+    getResolver: () => null,
+    setResolver: () => {},
+    getRestoreVisibleOverlayOnModalClose: () => restore,
+    });
+
+  const ok = runtime.sendToVisibleOverlay("runtime-options:open", undefined, {
+    restoreOnModalClose: "runtime-options",
+  });
+
+  assert.equal(ok, true);
+  assert.equal(visible, true);
+  assert.equal(restore.has("runtime-options"), true);
+  assert.deepEqual(sent, [["runtime-options:open"]]);
+});
+
+test("createFieldGroupingOverlayRuntimeService callback cancels when send fails", async () => {
+  let resolver: ((choice: KikuFieldGroupingChoice) => void) | null = null;
+  const runtime =
+    createFieldGroupingOverlayRuntimeService<"runtime-options" | "subsync">({
+      getMainWindow: () => null,
+      getVisibleOverlayVisible: () => false,
+      getInvisibleOverlayVisible: () => false,
+      setVisibleOverlayVisible: () => {},
+      setInvisibleOverlayVisible: () => {},
+      getResolver: () => resolver,
+      setResolver: (next) => {
+        resolver = next;
+      },
+      getRestoreVisibleOverlayOnModalClose: () =>
+        new Set<"runtime-options" | "subsync">(),
+    });
+
+  const callback = runtime.createFieldGroupingCallback();
+  const result = await callback({
+    original: {
+      noteId: 1,
+      expression: "a",
+      sentencePreview: "a",
+      hasAudio: false,
+      hasImage: false,
+      isOriginal: true,
+    },
+    duplicate: {
+      noteId: 2,
+      expression: "b",
+      sentencePreview: "b",
+      hasAudio: false,
+      hasImage: false,
+      isOriginal: false,
+    },
+  });
+
+  assert.equal(result.cancelled, true);
+  assert.equal(result.keepNoteId, 0);
+  assert.equal(result.deleteNoteId, 0);
+});

src/core/services/field-grouping-overlay-runtime-service.ts

@@ -0,0 +1,77 @@
+import {
+  KikuFieldGroupingChoice,
+  KikuFieldGroupingRequestData,
+} from "../../types";
+import {
+  createFieldGroupingCallbackRuntimeService,
+  sendToVisibleOverlayRuntimeService,
+} from "./overlay-bridge-runtime-service";
+
+interface WindowLike {
+  isDestroyed: () => boolean;
+  webContents: {
+    send: (channel: string, payload?: unknown) => void;
+  };
+}
+
+export interface FieldGroupingOverlayRuntimeOptions<T extends string> {
+  getMainWindow: () => WindowLike | null;
+  getVisibleOverlayVisible: () => boolean;
+  getInvisibleOverlayVisible: () => boolean;
+  setVisibleOverlayVisible: (visible: boolean) => void;
+  setInvisibleOverlayVisible: (visible: boolean) => void;
+  getResolver: () => ((choice: KikuFieldGroupingChoice) => void) | null;
+  setResolver: (
+    resolver: ((choice: KikuFieldGroupingChoice) => void) | null,
+  ) => void;
+  getRestoreVisibleOverlayOnModalClose: () => Set<T>;
+}
+
+export function createFieldGroupingOverlayRuntimeService<T extends string>(
+  options: FieldGroupingOverlayRuntimeOptions<T>,
+): {
+  sendToVisibleOverlay: (
+    channel: string,
+    payload?: unknown,
+    runtimeOptions?: { restoreOnModalClose?: T },
+  ) => boolean;
+  createFieldGroupingCallback: () => (
+    data: KikuFieldGroupingRequestData,
+  ) => Promise<KikuFieldGroupingChoice>;
+} {
+  const sendToVisibleOverlay = (
+    channel: string,
+    payload?: unknown,
+    runtimeOptions?: { restoreOnModalClose?: T },
+  ): boolean => {
+    return sendToVisibleOverlayRuntimeService({
+      mainWindow: options.getMainWindow() as never,
+      visibleOverlayVisible: options.getVisibleOverlayVisible(),
+      setVisibleOverlayVisible: options.setVisibleOverlayVisible,
+      channel,
+      payload,
+      restoreOnModalClose: runtimeOptions?.restoreOnModalClose,
+      restoreVisibleOverlayOnModalClose:
+        options.getRestoreVisibleOverlayOnModalClose(),
+    });
+  };
+
+  const createFieldGroupingCallback = (): ((
+    data: KikuFieldGroupingRequestData,
+  ) => Promise<KikuFieldGroupingChoice>) => {
+    return createFieldGroupingCallbackRuntimeService({
+      getVisibleOverlayVisible: options.getVisibleOverlayVisible,
+      getInvisibleOverlayVisible: options.getInvisibleOverlayVisible,
+      setVisibleOverlayVisible: options.setVisibleOverlayVisible,
+      setInvisibleOverlayVisible: options.setInvisibleOverlayVisible,
+      getResolver: options.getResolver,
+      setResolver: options.setResolver,
+      sendToVisibleOverlay,
+    });
+  };
+
+  return {
+    sendToVisibleOverlay,
+    createFieldGroupingCallback,
+  };
+}