mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-04-10 16:19:24 -07:00
Rename anime visibility heading to title visibility
- Update trends filter heading text - Add regression test for rendered label
This commit is contained in:
@@ -0,0 +1,34 @@
|
|||||||
|
---
|
||||||
|
id: TASK-285
|
||||||
|
title: Rename anime visibility filter heading to title visibility
|
||||||
|
status: Done
|
||||||
|
assignee:
|
||||||
|
- codex
|
||||||
|
created_date: '2026-04-10 00:00'
|
||||||
|
updated_date: '2026-04-10 00:00'
|
||||||
|
labels:
|
||||||
|
- stats
|
||||||
|
- ui
|
||||||
|
- bug
|
||||||
|
milestone: m-1
|
||||||
|
dependencies: []
|
||||||
|
references:
|
||||||
|
- stats/src/components/trends/TrendsTab.tsx
|
||||||
|
- stats/src/components/trends/TrendsTab.test.tsx
|
||||||
|
priority: low
|
||||||
|
ordinal: 200000
|
||||||
|
---
|
||||||
|
|
||||||
|
## Description
|
||||||
|
|
||||||
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
||||||
|
Align the library cumulative trends filter UI with the new terminology by renaming the hardcoded anime visibility heading to title visibility.
|
||||||
|
<!-- SECTION:DESCRIPTION:END -->
|
||||||
|
|
||||||
|
## Acceptance Criteria
|
||||||
|
|
||||||
|
<!-- AC:BEGIN -->
|
||||||
|
- [x] #1 The trends filter heading uses `Title Visibility`
|
||||||
|
- [x] #2 The component behavior and props stay unchanged
|
||||||
|
- [x] #3 A regression test covers the rendered heading text
|
||||||
|
<!-- AC:END -->
|
||||||
19
stats/src/components/trends/TrendsTab.test.tsx
Normal file
19
stats/src/components/trends/TrendsTab.test.tsx
Normal file
@@ -0,0 +1,19 @@
|
|||||||
|
import assert from 'node:assert/strict';
|
||||||
|
import test from 'node:test';
|
||||||
|
import { renderToStaticMarkup } from 'react-dom/server';
|
||||||
|
import { AnimeVisibilityFilter } from './TrendsTab';
|
||||||
|
|
||||||
|
test('AnimeVisibilityFilter uses title visibility wording', () => {
|
||||||
|
const markup = renderToStaticMarkup(
|
||||||
|
<AnimeVisibilityFilter
|
||||||
|
animeTitles={['KonoSuba']}
|
||||||
|
hiddenAnime={new Set()}
|
||||||
|
onShowAll={() => {}}
|
||||||
|
onHideAll={() => {}}
|
||||||
|
onToggleAnime={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.match(markup, /Title Visibility/);
|
||||||
|
assert.doesNotMatch(markup, /Anime Visibility/);
|
||||||
|
});
|
||||||
@@ -29,7 +29,7 @@ interface AnimeVisibilityFilterProps {
|
|||||||
onToggleAnime: (title: string) => void;
|
onToggleAnime: (title: string) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
function AnimeVisibilityFilter({
|
export function AnimeVisibilityFilter({
|
||||||
animeTitles,
|
animeTitles,
|
||||||
hiddenAnime,
|
hiddenAnime,
|
||||||
onShowAll,
|
onShowAll,
|
||||||
@@ -45,7 +45,7 @@ function AnimeVisibilityFilter({
|
|||||||
<div className="mb-2 flex items-center justify-between gap-3">
|
<div className="mb-2 flex items-center justify-between gap-3">
|
||||||
<div>
|
<div>
|
||||||
<h4 className="text-xs font-semibold uppercase tracking-widest text-ctp-subtext0">
|
<h4 className="text-xs font-semibold uppercase tracking-widest text-ctp-subtext0">
|
||||||
Anime Visibility
|
Title Visibility
|
||||||
</h4>
|
</h4>
|
||||||
<p className="mt-1 text-xs text-ctp-overlay1">
|
<p className="mt-1 text-xs text-ctp-overlay1">
|
||||||
Shared across all anime trend charts. Default: show everything.
|
Shared across all anime trend charts. Default: show everything.
|
||||||
|
|||||||
Reference in New Issue
Block a user