refactor(ipc): centralize contracts and validate payloads

2026-02-27 18:22:41 -08:00 · 2026-02-21 17:02:00 -08:00
parent 2a5830c4c5
commit 05be13be9e
16 changed files with 915 additions and 190 deletions
--- a/docs/subagents/INDEX.md
+++ b/docs/subagents/INDEX.md
@@ -54,6 +54,7 @@ Read first. Keep concise.
 | `opencode-task77-sliceb-20260221T232507Z-vzk5`                | `opencode-task77-sliceb`                | `Implement TASK-77 slice B parser-enrichment stage module + focused tests without touching tokenizer.ts`             | `done`        | `docs/subagents/agents/opencode-task77-sliceb-20260221T232507Z-vzk5.md`                | `2026-02-21T23:27:40Z` |
 | `opencode-task79-runtime-reducers-20260221T235652Z-n4p7`      | `opencode-task79-runtime-reducers`      | `Execute TASK-79 explicit runtime state transitions/reducers in main via plan-first workflow`                        | `done`        | `docs/subagents/agents/opencode-task79-runtime-reducers-20260221T235652Z-n4p7.md`      | `2026-02-22T00:10:51Z` |
 | `opencode-task79-sliceb-20260222T000253Z-m2r7`                | `opencode-task79-sliceb`                | `Implement TASK-79 slice B invariants coverage/tests and composition-boundary docs updates without commit`           | `done`        | `docs/subagents/agents/opencode-task79-sliceb-20260222T000253Z-m2r7.md`                | `2026-02-22T00:04:21Z` |
-| `opencode-task80-ipc-contract-20260222T001728Z-obrv`          | `opencode-task80-ipc-contract`          | `Execute TASK-80 IPC contract typing + runtime payload validation end-to-end without commit`                         | `planning`    | `docs/subagents/agents/opencode-task80-ipc-contract-20260222T001728Z-obrv.md`          | `2026-02-22T00:17:28Z` |
+| `opencode-task80-ipc-contract-20260222T001728Z-obrv`          | `opencode-task80-ipc-contract`          | `Execute TASK-80 IPC contract typing + runtime payload validation end-to-end without commit`                         | `done`        | `docs/subagents/agents/opencode-task80-ipc-contract-20260222T001728Z-obrv.md`          | `2026-02-22T00:56:00Z` |
 | `opencode-task82-smoke-20260222T002150Z-p5bp`                 | `opencode-task82-smoke`                 | `Execute TASK-82 e2e smoke suite for launcher/mpv/ipc/overlay end-to-end without commit`                             | `done`        | `docs/subagents/agents/opencode-task82-smoke-20260222T002150Z-p5bp.md`                 | `2026-02-22T00:54:29Z` |
 | `codex-task82-smoke-20260222T002523Z-3j7u`                    | `codex-task82-smoke`                    | `Execute TASK-82 e2e smoke suite for launcher/mpv/ipc/overlay end-to-end without commit`                             | `done`        | `docs/subagents/agents/codex-task82-smoke-20260222T002523Z-3j7u.md`                    | `2026-02-22T00:53:25Z` |
+| `opencode-task81-launcher-modules-20260222T005725Z-8oh8`      | `opencode-task81-launcher-modules`      | `Execute TASK-81 launcher command-module/process-adapter refactor end-to-end without commit`                         | `in_progress` | `docs/subagents/agents/opencode-task81-launcher-modules-20260222T005725Z-8oh8.md`      | `2026-02-22T00:57:25Z` |
--- a/docs/subagents/agents/opencode-task80-ipc-contract-20260222T001728Z-obrv.md
+++ b/docs/subagents/agents/opencode-task80-ipc-contract-20260222T001728Z-obrv.md
@@ -2,9 +2,9 @@

 - alias: `opencode-task80-ipc-contract`
 - mission: `Execute TASK-80 IPC contract typing + runtime payload validation via writing-plans + executing-plans (no commit).`
- status: `planning`
+- status: `done`
 - started_utc: `2026-02-22T00:17:28Z`
- last_update_utc: `2026-02-22T00:17:28Z`
+- last_update_utc: `2026-02-22T00:56:00Z`

 ## Intent

@@ -20,6 +20,22 @@
 - `src/main/**/*.test.ts`
 - `docs/architecture.md`

+## Files Touched
+
+- `src/shared/ipc/contracts.ts`
+- `src/shared/ipc/validators.ts`
+- `src/core/services/ipc.ts`
+- `src/core/services/anki-jimaku-ipc.ts`
+- `src/preload.ts`
+- `src/main/dependencies.ts`
+- `src/main.ts`
+- `src/main/runtime/composers/ipc-runtime-composer.ts`
+- `src/main/runtime/composers/ipc-runtime-composer.test.ts`
+- `src/core/services/ipc.test.ts`
+- `src/core/services/anki-jimaku-ipc.test.ts`
+- `package.json`
+- `docs/architecture.md`
+
 ## Assumptions

 - TASK-80 scope is main-process IPC boundary; keep external behavior/backward compatibility.
@@ -29,3 +45,6 @@
 ## Phase Log

 - `2026-02-22T00:17:28Z` Session started; read backlog overview and TASK-80 details; beginning planning.
+- `2026-02-22T00:21:00Z` Plan written to `docs/plans/2026-02-22-task-80-ipc-contract-validation.md` and recorded in Backlog TASK-80.
+- `2026-02-22T00:55:30Z` Implemented IPC contract/constants + validators and rewired main/preload/anki-jimaku IPC boundary handlers with runtime payload checks and graceful malformed handling.
+- `2026-02-22T00:56:00Z` Validation complete: `bun run build`, `bun run test:core:src`, `bun run test:core:dist` all passing; TASK-80 finalized Done in Backlog.
--- a/docs/subagents/collaboration.md
+++ b/docs/subagents/collaboration.md
@@ -74,5 +74,7 @@ Shared notes. Append-only.
 - [2026-02-22T00:17:28Z] [opencode-task80-ipc-contract-20260222T001728Z-obrv|opencode-task80-ipc-contract] starting TASK-80 via Backlog MCP + writing-plans/executing-plans; scope IPC contract typing/runtime payload validation + malformed payload tests; will parallelize independent slices where possible.
 - [2026-02-22T00:21:50Z] [opencode-task82-smoke-20260222T002150Z-p5bp|opencode-task82-smoke] starting TASK-82 via Backlog MCP + writing-plans/executing-plans; scope e2e smoke suite for launcher mpv ipc overlay startup + workflow/docs wiring, no commit.
 - [2026-02-22T00:25:23Z] [codex-task82-smoke-20260222T002523Z-3j7u|codex-task82-smoke] overlap note: taking active TASK-82 execution; reusing existing task context/plan artifact, scoping edits to launcher smoke test + workflow/docs wiring + backlog evidence updates only.
+- [2026-02-22T00:56:00Z] [opencode-task80-ipc-contract-20260222T001728Z-obrv|opencode-task80-ipc-contract] completed TASK-80: added central IPC contract + boundary validators (`src/shared/ipc/*`), rewired main/preload/anki-jimaku IPC channel usage, added malformed payload tests (`ipc.test.ts`, `anki-jimaku-ipc.test.ts`), docs updated (`docs/architecture.md`), build + core src/dist tests green, and backlog TASK-80 marked Done.
 - [2026-02-22T00:54:29Z] [opencode-task82-smoke-20260222T002150Z-p5bp|opencode-task82-smoke] completed TASK-82 implementation pass: launcher smoke e2e stabilized (`launcher/smoke.e2e.test.ts`), CI/release smoke + artifact upload wired, docs updated (`docs/development.md`, `docs/installation.md`), and verification lanes green (`test:launcher:smoke:src`, `test:launcher`, `test:fast`, `build`, `test:smoke:dist`, `docs:build`).
 - [2026-02-22T00:53:25Z] [codex-task82-smoke-20260222T002523Z-3j7u|codex-task82-smoke] completed TASK-82: added `launcher/smoke.e2e.test.ts`, wired `test:launcher:smoke:src` + CI/release smoke gates with `.tmp/launcher-smoke` failure artifact upload, docs updated (`docs/development.md`, `docs/installation.md`), launcher/fast/docs lanes green; `build + test:smoke:dist` still blocked by unrelated TASK-80 IPC typing errors.
+- [2026-02-22T00:57:25Z] [opencode-task81-launcher-modules-20260222T005725Z-8oh8|opencode-task81-launcher-modules] starting TASK-81 via Backlog MCP + writing-plans/executing-plans; expected scope `launcher/main.ts` command extraction, process adapters, and launcher tests while preserving CLI behavior/exit codes.