fix: address coderabbit feedback

This commit is contained in:
2026-05-03 21:07:02 -07:00
parent b245ca642d
commit 040741cf57
13 changed files with 207 additions and 21 deletions
+43
View File
@@ -559,6 +559,49 @@ do
)
end
do
local recorded, err = run_plugin_scenario({
process_list = "",
option_overrides = {
binary_path = binary_path,
auto_start = "yes",
auto_start_visible_overlay = "yes",
auto_start_pause_until_ready = "yes",
socket_path = "/tmp/subminer-socket",
},
input_ipc_server = "/tmp/subminer-socket",
media_title = "Random Movie",
files = {
[binary_path] = true,
},
})
assert_true(recorded ~= nil, "plugin failed to load for pre-ready duplicate auto-start scenario: " .. tostring(err))
fire_event(recorded, "file-loaded")
fire_event(recorded, "file-loaded")
assert_true(recorded.script_messages["subminer-autoplay-ready"] ~= nil, "subminer-autoplay-ready script message not registered")
assert_true(
count_start_calls(recorded.async_calls) == 1,
"pre-ready duplicate auto-start should not issue duplicate --start commands"
)
assert_true(
count_property_set(recorded.property_sets, "pause", true) == 1,
"pre-ready duplicate auto-start should not repeat the pause gate"
)
assert_true(
count_property_set(recorded.property_sets, "pause", false) == 0,
"pre-ready duplicate auto-start should not resume playback before tokenization is ready"
)
assert_true(
count_osd_message(recorded.osd, "SubMiner: Loading subtitle tokenization...") == 1,
"pre-ready duplicate auto-start should not repeat the loading OSD"
)
recorded.script_messages["subminer-autoplay-ready"]()
assert_true(
count_property_set(recorded.property_sets, "pause", false) == 1,
"autoplay-ready should resume the original pre-ready gate"
)
end
do
local recorded, err = run_plugin_scenario({
process_list = "",